From: Greg KH <gregkh@linuxfoundation.org>
To: Matteo Semenzato <mattew8898@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] Staging: dgnc: replace EXTRA_CFLAGS
Date: Sun, 1 Mar 2015 09:26:07 -0800 [thread overview]
Message-ID: <20150301172607.GA30867@kroah.com> (raw)
In-Reply-To: <1425230397-29956-1-git-send-email-mattew8898@gmail.com>
On Sun, Mar 01, 2015 at 06:19:57PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
>
> This patch removes EXTRA_CFLAGS from the Makefile and defines DDG_PART
> in dgnc_driver.h
>
> Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
> ---
> drivers/staging/dgnc/Makefile | 2 --
> drivers/staging/dgnc/dgnc_driver.h | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
> index b69f7b6..995c874 100644
> --- a/drivers/staging/dgnc/Makefile
> +++ b/drivers/staging/dgnc/Makefile
> @@ -1,5 +1,3 @@
> -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
> -
> obj-$(CONFIG_DGNC) += dgnc.o
>
> dgnc-objs := dgnc_cls.o dgnc_driver.o\
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index a8157eb..0b718a8 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -46,6 +46,7 @@
> #define PROCSTR "dgnc" /* /proc entries */
> #define DEVSTR "/dev/dg/dgnc" /* /dev entries */
> #define DRVSTR "dgnc" /* Driver name string */
> +#define DG_PART "40002369_F"
Why do we need this define?
And why doesn't it use the same formatting as the other ones in this
list?
next prev parent reply other threads:[~2015-03-01 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 8:41 [PATCH] Staging: dgnc: replace EXTRA_CFLAGS Matteo Semenzato
2015-03-01 16:41 ` Greg KH
2015-03-01 17:19 ` [PATCH V2] " Matteo Semenzato
2015-03-01 17:26 ` Greg KH [this message]
2015-03-01 17:40 ` Matteo Semenzato
2015-03-01 18:05 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2015-03-01 18:35 Matteo Semenzato
2015-03-01 19:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150301172607.GA30867@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=mattew8898@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox