Re: [PATCH V2] Staging: dgnc: replace EXTRA_CFLAGS

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Mar 01, 2015 at 06:40:05PM +0100, Matteo Semenzato wrote:
> Il giorno dom, 01/03/2015 alle 09.26 -0800, Greg KH ha scritto:
> > On Sun, Mar 01, 2015 at 06:19:57PM +0100, Matteo Semenzato wrote:
> > > From: Matteo Semenzato <mattew8898@gmail.com>
> > > 
> > > This patch removes EXTRA_CFLAGS from the Makefile and defines DDG_PART
> > > in dgnc_driver.h
> > > 
> > > Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
> > > ---
> > >  drivers/staging/dgnc/Makefile      | 2 --
> > >  drivers/staging/dgnc/dgnc_driver.h | 1 +
> > >  2 files changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
> > > index b69f7b6..995c874 100644
> > > --- a/drivers/staging/dgnc/Makefile
> > > +++ b/drivers/staging/dgnc/Makefile
> > > @@ -1,5 +1,3 @@
> > > -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
> > > -
> > >  obj-$(CONFIG_DGNC) += dgnc.o
> > >  
> > >  dgnc-objs :=   dgnc_cls.o dgnc_driver.o\
> > > diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> > > index a8157eb..0b718a8 100644
> > > --- a/drivers/staging/dgnc/dgnc_driver.h
> > > +++ b/drivers/staging/dgnc/dgnc_driver.h
> > > @@ -46,6 +46,7 @@
> > >  #define	PROCSTR		"dgnc"			/* /proc entries	 */
> > >  #define	DEVSTR		"/dev/dg/dgnc"		/* /dev entries		 */
> > >  #define	DRVSTR		"dgnc"			/* Driver name string	 */
> > > +#define DG_PART		"40002369_F"
> > 
> > Why do we need this define?
> > 
> > And why doesn't it use the same formatting as the other ones in this
> > list?
> 
> DG_PART is being used in dgnc_mgmt.c and dgnc_sysfs.c

What it is being used for?  Can it be removed?  Is it just there for
informational purposes or does the code actually do something based on
the value?

thanks,

greg k-h