From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753178AbbCASFJ (ORCPT ); Sun, 1 Mar 2015 13:05:09 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47296 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbbCASFH (ORCPT ); Sun, 1 Mar 2015 13:05:07 -0500 Date: Sun, 1 Mar 2015 10:05:06 -0800 From: Greg KH To: 1425199286-16376-1-git-send-email-mattew8898@gmail.com Cc: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] Staging: dgnc: replace EXTRA_CFLAGS Message-ID: <20150301180506.GA32433@kroah.com> References: <1425199286-16376-1-git-send-email-mattew8898@gmail.com> <1425230397-29956-1-git-send-email-mattew8898@gmail.com> <20150301172607.GA30867@kroah.com> <1425231605.3928.5.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425231605.3928.5.camel@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 01, 2015 at 06:40:05PM +0100, Matteo Semenzato wrote: > Il giorno dom, 01/03/2015 alle 09.26 -0800, Greg KH ha scritto: > > On Sun, Mar 01, 2015 at 06:19:57PM +0100, Matteo Semenzato wrote: > > > From: Matteo Semenzato > > > > > > This patch removes EXTRA_CFLAGS from the Makefile and defines DDG_PART > > > in dgnc_driver.h > > > > > > Signed-off-by: Matteo Semenzato > > > --- > > > drivers/staging/dgnc/Makefile | 2 -- > > > drivers/staging/dgnc/dgnc_driver.h | 1 + > > > 2 files changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile > > > index b69f7b6..995c874 100644 > > > --- a/drivers/staging/dgnc/Makefile > > > +++ b/drivers/staging/dgnc/Makefile > > > @@ -1,5 +1,3 @@ > > > -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\" > > > - > > > obj-$(CONFIG_DGNC) += dgnc.o > > > > > > dgnc-objs := dgnc_cls.o dgnc_driver.o\ > > > diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h > > > index a8157eb..0b718a8 100644 > > > --- a/drivers/staging/dgnc/dgnc_driver.h > > > +++ b/drivers/staging/dgnc/dgnc_driver.h > > > @@ -46,6 +46,7 @@ > > > #define PROCSTR "dgnc" /* /proc entries */ > > > #define DEVSTR "/dev/dg/dgnc" /* /dev entries */ > > > #define DRVSTR "dgnc" /* Driver name string */ > > > +#define DG_PART "40002369_F" > > > > Why do we need this define? > > > > And why doesn't it use the same formatting as the other ones in this > > list? > > DG_PART is being used in dgnc_mgmt.c and dgnc_sysfs.c What it is being used for? Can it be removed? Is it just there for informational purposes or does the code actually do something based on the value? thanks, greg k-h