From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbbCAT4S (ORCPT ); Sun, 1 Mar 2015 14:56:18 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48135 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbbCAT4Q (ORCPT ); Sun, 1 Mar 2015 14:56:16 -0500 Date: Sun, 1 Mar 2015 11:56:12 -0800 From: Greg KH To: 20150301180506.GA32433@kroah.com Cc: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] Staging: dgnc: replace EXTRA_CFLAGS Message-ID: <20150301195612.GA8469@kroah.com> References: <1425234902.3928.14.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425234902.3928.14.camel@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 01, 2015 at 07:35:02PM +0100, Matteo Semenzato wrote: > On Sun, 1 Mar 2015 10:05:06 -0800, Greg KH wrote: > > What it is being used for? Can it be removed? Is it just there for > > informational purposes or does the code actually do something based on > > the value? > > The value is used to create a file called version in the driver's sysfs > directory, the file is read-only. That's useless, it is a built-time thing, just remove the sysfs file as well. thanks, greg k-h