From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752756AbbCAXCd (ORCPT ); Sun, 1 Mar 2015 18:02:33 -0500 Received: from mout.gmx.net ([212.227.17.20]:51925 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbbCAXCb convert rfc822-to-8bit (ORCPT ); Sun, 1 Mar 2015 18:02:31 -0500 From: Peter =?iso-8859-15?q?H=FCwe?= To: Jarkko Sakkinen Subject: Re: [PATCH] tpm: fix call order in tpm-chip.c Date: Mon, 2 Mar 2015 00:06:52 +0100 User-Agent: KMail/1.13.7 (Linux/3.18.5-dirty; KDE/4.14.3; x86_64; ; ) Cc: Ashley Lai , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, christophe.ricard@gmail.com, jason.gunthorpe@obsidianresearch.com, stefanb@linux.vnet.ibm.com References: <1425246947-3336-1-git-send-email-jarkko.sakkinen@linux.intel.com> In-Reply-To: <1425246947-3336-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Message-Id: <201503020006.54651.PeterHuewe@gmx.de> X-Provags-ID: V03:K0:yh2yyu6zjsoaRK4LdjKuYDrevjkPtgdUcFa/wO5fj0jUUie2ETo +6r3joKAaPbhZ/87ZRYqMBcKZ0pcG7gSEthjRMEyKVqj2HqQ5oeFYk2OzOPgyhNln1a/3O0 vqCrb1ze7RT/fwUwncyuVCFJdoHXwjS3YmPhkXTwDuVuP8QtoRl5S7+JIbu3k+fx3htkxq1 osFU0Xq+tz8KTSd4xFY4g== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, 1. März 2015, 22:55:47 schrieb Jarkko Sakkinen: > - tpm_dev_add_device(): cdev_add() must be done before uevent is > propagated in order to avoid races. > - tpm_chip_register(): tpm_dev_add_device() must be done as the > last step before exposing device to the user space in order to > avoid races. > > In addition clarified description in tpm_chip_register(). > > Signed-off-by: Jarkko Sakkinen Looks good to me. Staged it and I'll send out the pull request in the next few days. (have to catch up mails from traveling) Thanks, Peter