* [PATCH v4 2/3] staging: lustre: fix coding style errors
2015-02-10 18:36 [PATCH v4 1/3] staging: lustre: fix coding style errors Tal Shorer
@ 2015-02-10 18:36 ` Tal Shorer
2015-03-02 1:28 ` Greg KH
2015-02-10 18:36 ` [PATCH v4 3/3] staging: lustre: fix coding style errors fix the Tal Shorer
2015-03-02 1:27 ` [PATCH v4 1/3] staging: lustre: fix coding style errors Greg KH
2 siblings, 1 reply; 6+ messages in thread
From: Tal Shorer @ 2015-02-10 18:36 UTC (permalink / raw)
To: linux-kernel
Cc: oleg.drokin, devel, andreas.dilger, gregkh, clabbe.montjoie,
dan.carpenter, tal.shorer
fix the following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
initialization of min_watchdog_ratelimit (static int) to 0
for clarity's sake, the "= 0" is kept as part of a comment
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
index 7c259af..c3d00e6 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
@@ -165,7 +165,7 @@ static int proc_dobitmasks(struct ctl_table *table, int write,
__proc_dobitmasks);
}
-static int min_watchdog_ratelimit = 0; /* disable ratelimiting */
+static int min_watchdog_ratelimit; /* = 0 disable ratelimiting */
static int max_watchdog_ratelimit = (24*60*60); /* limit to once per day */
static int __proc_dump_kernel(void *data, int write,
--
2.2.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/3] staging: lustre: fix coding style errors
2015-02-10 18:36 ` [PATCH v4 2/3] " Tal Shorer
@ 2015-03-02 1:28 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2015-03-02 1:28 UTC (permalink / raw)
To: Tal Shorer
Cc: linux-kernel, devel, andreas.dilger, oleg.drokin, clabbe.montjoie,
dan.carpenter
On Tue, Feb 10, 2015 at 08:36:20PM +0200, Tal Shorer wrote:
> fix the following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
> initialization of min_watchdog_ratelimit (static int) to 0
>
> for clarity's sake, the "= 0" is kept as part of a comment
>
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Same exact subject as 1/3, yet it does something different, which makes
no sense :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v4 3/3] staging: lustre: fix coding style errors fix the
2015-02-10 18:36 [PATCH v4 1/3] staging: lustre: fix coding style errors Tal Shorer
2015-02-10 18:36 ` [PATCH v4 2/3] " Tal Shorer
@ 2015-02-10 18:36 ` Tal Shorer
2015-03-02 1:27 ` Greg KH
2015-03-02 1:27 ` [PATCH v4 1/3] staging: lustre: fix coding style errors Greg KH
2 siblings, 1 reply; 6+ messages in thread
From: Tal Shorer @ 2015-02-10 18:36 UTC (permalink / raw)
To: linux-kernel
Cc: oleg.drokin, devel, andreas.dilger, gregkh, clabbe.montjoie,
dan.carpenter, tal.shorer
following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
missing spaces around '='
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
index c3d00e6..d70330f 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
@@ -308,7 +308,7 @@ static int proc_console_backoff(struct ctl_table *table, int write,
dummy.proc_handler = &proc_dointvec;
if (!write) { /* read */
- backoff= libcfs_console_backoff;
+ backoff = libcfs_console_backoff;
rc = proc_dointvec(&dummy, write, buffer, lenp, ppos);
return rc;
}
--
2.2.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v4 3/3] staging: lustre: fix coding style errors fix the
2015-02-10 18:36 ` [PATCH v4 3/3] staging: lustre: fix coding style errors fix the Tal Shorer
@ 2015-03-02 1:27 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2015-03-02 1:27 UTC (permalink / raw)
To: Tal Shorer
Cc: linux-kernel, devel, andreas.dilger, oleg.drokin, clabbe.montjoie,
dan.carpenter
On Tue, Feb 10, 2015 at 08:36:21PM +0200, Tal Shorer wrote:
> following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
> missing spaces around '='
>
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Your subject doesn't make sense :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/3] staging: lustre: fix coding style errors
2015-02-10 18:36 [PATCH v4 1/3] staging: lustre: fix coding style errors Tal Shorer
2015-02-10 18:36 ` [PATCH v4 2/3] " Tal Shorer
2015-02-10 18:36 ` [PATCH v4 3/3] staging: lustre: fix coding style errors fix the Tal Shorer
@ 2015-03-02 1:27 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2015-03-02 1:27 UTC (permalink / raw)
To: Tal Shorer
Cc: linux-kernel, devel, andreas.dilger, oleg.drokin, clabbe.montjoie,
dan.carpenter
On Tue, Feb 10, 2015 at 08:36:19PM +0200, Tal Shorer wrote:
> fix the following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
> initialization of lnet_table_header (static pointer) to NULL
>
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please put the error you are fixing in the subject, otherwise we have
no idea :(
^ permalink raw reply [flat|nested] 6+ messages in thread