From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matteo Semenzato <mattew8898@gmail.com>
Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] Staging: fbtft: fix coding style errors
Date: Mon, 2 Mar 2015 12:29:04 +0300 [thread overview]
Message-ID: <20150302092904.GD5386@mwanda> (raw)
In-Reply-To: <1425145050-486-1-git-send-email-mattew8898@gmail.com>
On Sat, Feb 28, 2015 at 06:37:30PM +0100, Matteo Semenzato wrote:
> static int hy28b_init_sequence[] = {
> - -1,0x00e7,0x0010,-1,0x0000,0x0001,-1,0x0001,0x0100,-1,0x0002,0x0700,
> - -1,0x0003,0x1030,-1,0x0004,0x0000,-1,0x0008,0x0207,-1,0x0009,0x0000,
> - -1,0x000a,0x0000,-1,0x000c,0x0001,-1,0x000d,0x0000,-1,0x000f,0x0000,
> - -1,0x0010,0x0000,-1,0x0011,0x0007,-1,0x0012,0x0000,-1,0x0013,0x0000,
> - -2,50,-1,0x0010,0x1590,-1,0x0011,0x0227,-2,50,-1,0x0012,0x009c,-2,50,
> - -1,0x0013,0x1900,-1,0x0029,0x0023,-1,0x002b,0x000e,-2,50,
> - -1,0x0020,0x0000,-1,0x0021,0x0000,-2,50,-1,0x0050,0x0000,
> - -1,0x0051,0x00ef,-1,0x0052,0x0000,-1,0x0053,0x013f,-1,0x0060,0xa700,
> - -1,0x0061,0x0001,-1,0x006a,0x0000,-1,0x0080,0x0000,-1,0x0081,0x0000,
> - -1,0x0082,0x0000,-1,0x0083,0x0000,-1,0x0084,0x0000,-1,0x0085,0x0000,
> - -1,0x0090,0x0010,-1,0x0092,0x0000,-1,0x0093,0x0003,-1,0x0095,0x0110,
> - -1,0x0097,0x0000,-1,0x0098,0x0000,-1,0x0007,0x0133,-1,0x0020,0x0000,
> - -1,0x0021,0x0000,-2,100,-3 };
> + -1, 0x00e7, 0x0010,
> + -1, 0x0000, 0x0001,
> + -1, 0x0001, 0x0100,
> + -1, 0x0002, 0x0700,
> + -1, 0x0003, 0x1030,
> + -1, 0x0004, 0x0000,
> + -1, 0x0008, 0x0207,
> + -1, 0x0009, 0x0000,
> + -1, 0x000a, 0x0000,
> + -1, 0x000c, 0x0001,
> + -1, 0x000d, 0x0000,
> + -1, 0x000f, 0x0000,
> + -1, 0x0010, 0x0000,
> + -1, 0x0011, 0x0007,
> + -1, 0x0012, 0x0000,
> + -1, 0x0013, 0x0000,
> + -2, 50,
> + -1, 0x0010, 0x1590,
> + -1, 0x0011, 0x0227,
> + -2, 50,
> + -1, 0x0012, 0x009c,
> + -2, 50,
> + -1, 0x0013, 0x1900,
> + -1, 0x0029, 0x0023,
> + -1, 0x002b, 0x000e,
> + -2, 50,
> + -1, 0x0020, 0x0000,
> + -1, 0x0021, 0x0000,
> + -2, 50,
> + -1, 0x0050, 0x0000,
> + -1, 0x0051, 0x00ef,
> + -1, 0x0052, 0x0000,
> + -1, 0x0053, 0x013f,
> + -1, 0x0060, 0xa700,
> + -1, 0x0061, 0x0001,
> + -1, 0x006a, 0x0000,
> + -1, 0x0080, 0x0000,
> + -1, 0x0081, 0x0000,
> + -1, 0x0082, 0x0000,
> + -1, 0x0083, 0x0000,
> + -1, 0x0084, 0x0000,
> + -1, 0x0085, 0x0000,
> + -1, 0x0090, 0x0010,
> + -1, 0x0092, 0x0000,
> + -1, 0x0093, 0x0003,
> + -1, 0x0095, 0x0110,
> + -1, 0x0097, 0x0000,
> + -1, 0x0098, 0x0000,
> + -1, 0x0007, 0x0133,
> + -1, 0x0020, 0x0000,
> + -1, 0x0021, 0x0000,
> + -2, 100,
> + -3
> +};
For some reason you put the line breaks at the negative numbers? Why?
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-02 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 14:31 [PATCH] Staging: fbtft: fix coding style errors Matteo Semenzato
2015-02-28 17:37 ` [PATCH V2] " Matteo Semenzato
2015-03-02 1:17 ` Greg KH
2015-03-02 9:29 ` Dan Carpenter [this message]
2015-03-02 13:15 ` Matteo Semenzato
2015-03-02 13:23 ` Dan Carpenter
2015-03-02 13:35 ` Matteo Semenzato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302092904.GD5386@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattew8898@gmail.com \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox