From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754054AbbCBLpg (ORCPT ); Mon, 2 Mar 2015 06:45:36 -0500 Received: from mail-pd0-f169.google.com ([209.85.192.169]:39666 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbbCBLpd (ORCPT ); Mon, 2 Mar 2015 06:45:33 -0500 Date: Mon, 2 Mar 2015 19:45:17 +0800 From: Shawn Guo To: Stefan Agner Cc: linus.walleij@linaro.org, u.kleine-koenig@pengutronix.de, kernel@pengutronix.de, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: imx: do not implicitly set pin regs to -1 Message-ID: <20150302114516.GC3040@dragon> References: <1423240256-27210-1-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423240256-27210-1-git-send-email-stefan@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote: > Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs > the values in struct imx_pin_reg to be -1. This has been done in a > rather unorthodox way by setting the memory to 0xff using memset... > Use a proper for loop to initialize the whole array with -1. > > Signed-off-by: Stefan Agner Acked-by: Shawn Guo