From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Matteo Semenzato <mattew8898@gmail.com>,
gregkh@linuxfoundation.org, oat.elena@gmail.com,
andriy.shevchenko@linux.intel.com, hejianet@gmail.com,
tapaswenipathak@gmail.com, cengelma@gmx.at,
abelmoyo.ab@gmail.com, kristina.martsenko@gmail.com,
standby24x7@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: fix coding style errors
Date: Mon, 2 Mar 2015 18:05:27 +0530 [thread overview]
Message-ID: <20150302123527.GA4278@sudip-PC> (raw)
In-Reply-To: <20150302084657.GB5386@mwanda>
On Mon, Mar 02, 2015 at 11:46:57AM +0300, Dan Carpenter wrote:
> On Fri, Feb 27, 2015 at 10:58:28AM -0600, Larry Finger wrote:
> > On 02/27/2015 10:44 AM, Matteo Semenzato wrote:
> > >From: Matteo Semenzato <mattew8898@gmail.com>
> > >
> > >This patch fixes the following errors:
> > >ERROR: space prohibited before that ',' (ctx:WxW)
> > >ERROR: space prohibited before that ',' (ctx:WxW)
> > >ERROR: switch and case should be at the same indent
> > >
> > >Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
> >
> > I appreciate your efforts, but you are not improving the source.
> > Running scripts/checkpatch.pl against your patch results in the
> > following summary:
> >
> > total: 60 errors, 32 warnings, 352 lines checked
> >
> > You have fixed 60 errors, and introduced 60 new ones. :(
>
> That's weird. I only get the 32 warnings. Those are all long line
> warnings which were there in the original code as well.
yes, same here. I didn't get any new warnings. But since Matteo Semenzato is sending a new patch so i chose not to reply.
regards
sudip
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2015-03-02 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 16:44 [PATCH] Staging: rtl8188eu: fix coding style errors Matteo Semenzato
2015-02-27 16:53 ` Greg KH
2015-02-27 16:58 ` Larry Finger
2015-03-02 8:46 ` Dan Carpenter
2015-03-02 12:35 ` Sudip Mukherjee [this message]
2015-03-02 8:02 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302123527.GA4278@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=abelmoyo.ab@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cengelma@gmx.at \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hejianet@gmail.com \
--cc=kristina.martsenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mattew8898@gmail.com \
--cc=oat.elena@gmail.com \
--cc=standby24x7@gmail.com \
--cc=tapaswenipathak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox