From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753989AbbCBMfl (ORCPT ); Mon, 2 Mar 2015 07:35:41 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:32856 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbbCBMfk (ORCPT ); Mon, 2 Mar 2015 07:35:40 -0500 Date: Mon, 2 Mar 2015 18:05:27 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: Larry Finger , Matteo Semenzato , gregkh@linuxfoundation.org, oat.elena@gmail.com, andriy.shevchenko@linux.intel.com, hejianet@gmail.com, tapaswenipathak@gmail.com, cengelma@gmx.at, abelmoyo.ab@gmail.com, kristina.martsenko@gmail.com, standby24x7@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8188eu: fix coding style errors Message-ID: <20150302123527.GA4278@sudip-PC> References: <1425055449-7742-1-git-send-email-mattew8898@gmail.com> <54F0A234.5090404@lwfinger.net> <20150302084657.GB5386@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150302084657.GB5386@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2015 at 11:46:57AM +0300, Dan Carpenter wrote: > On Fri, Feb 27, 2015 at 10:58:28AM -0600, Larry Finger wrote: > > On 02/27/2015 10:44 AM, Matteo Semenzato wrote: > > >From: Matteo Semenzato > > > > > >This patch fixes the following errors: > > >ERROR: space prohibited before that ',' (ctx:WxW) > > >ERROR: space prohibited before that ',' (ctx:WxW) > > >ERROR: switch and case should be at the same indent > > > > > >Signed-off-by: Matteo Semenzato > > > > I appreciate your efforts, but you are not improving the source. > > Running scripts/checkpatch.pl against your patch results in the > > following summary: > > > > total: 60 errors, 32 warnings, 352 lines checked > > > > You have fixed 60 errors, and introduced 60 new ones. :( > > That's weird. I only get the 32 warnings. Those are all long line > warnings which were there in the original code as well. yes, same here. I didn't get any new warnings. But since Matteo Semenzato is sending a new patch so i chose not to reply. regards sudip > > regards, > dan carpenter >