From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754427AbbCBNbG (ORCPT ); Mon, 2 Mar 2015 08:31:06 -0500 Received: from mail.skyhub.de ([78.46.96.112]:53755 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754072AbbCBNbA (ORCPT ); Mon, 2 Mar 2015 08:31:00 -0500 Date: Mon, 2 Mar 2015 14:29:50 +0100 From: Borislav Petkov To: Quentin Casasnovas Cc: x86-ml , lkml Subject: Re: [GIT PULL] microcode loader updates Message-ID: <20150302132950.GC17521@pd.tnic> References: <20150302123441.GB17521@pd.tnic> <20150302130336.GB14850@chrystal.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150302130336.GB14850@chrystal.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2015 at 02:03:36PM +0100, Quentin Casasnovas wrote: > So at the last loop iteration for j == i, we'll do kfree(saved_ptr[j]) > which AFAICT hasn't been initialized yet. Using a kcalloc() your first > allocation for saved_ptr should just work since the memory will be cleared > and kfree(NULL) doesn't do anything. You're correct, but(!)... Practically, this is not a problem because @mc_saved_src being handed down to save_microcode() is at both call sites initialized up to mc_saved_count elements and the loop in save_microcode() only inspects this far. So actually, this test is not really needed: if (!mc_saved_src[i]) { ret = -EINVAL; goto err; } AFAICT and if I'm not missing anything else, of course. In any case, I'd like to keep this series cleanup-only (well, except this one) and address your comments later. Don't worry, I haven't forgotten them - I want to *not* fix everything in one go. Agreed? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --