From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754851AbbCBV5A (ORCPT ); Mon, 2 Mar 2015 16:57:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43913 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754480AbbCBV47 (ORCPT ); Mon, 2 Mar 2015 16:56:59 -0500 Date: Mon, 2 Mar 2015 13:56:57 -0800 From: Andrew Morton To: Valentin Rothberg Cc: iss_storagedev@hp.com, linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH] block/cpqarray.c: remove IRQF_DISABLED flag Message-Id: <20150302135657.e8a3dfa54fae3d15f658b3b5@linux-foundation.org> In-Reply-To: <1425040375-20528-1-git-send-email-Valentin.Rothberg@lip6.fr> References: <1425040375-20528-1-git-send-email-Valentin.Rothberg@lip6.fr> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Feb 2015 13:32:55 +0100 Valentin Rothberg wrote: > The IRQF_DISABLED is a NOOP and scheduled to be removed. According to > Ingo Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ > handlers with interrupts enabled can cause stack overflows when the > interrupt line of the issuing device is still active. > I suggest you prepare a patch which removes IRQF_DISABLED entirely. Several drivers still use it and it is possible that they have been buggy for some time, so we should be careful to cc the relevant maintainers (they probably don't exist) so they can check out what's going on in their code.