From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754323AbbCBPxT (ORCPT ); Mon, 2 Mar 2015 10:53:19 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:38834 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbbCBPxS (ORCPT ); Mon, 2 Mar 2015 10:53:18 -0500 Date: Mon, 2 Mar 2015 16:53:15 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Stefan Agner Cc: Shawn Guo , linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] pinctrl: imx: do not implicitly set pin regs to -1 Message-ID: <20150302155315.GD7865@pengutronix.de> References: <1423240256-27210-1-git-send-email-stefan@agner.ch> <20150302114516.GC3040@dragon> <20150302125935.GC7865@pengutronix.de> <43491e2cb2c520d8f15d90ae99a82f28@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <43491e2cb2c520d8f15d90ae99a82f28@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Mar 02, 2015 at 02:42:01PM +0100, Stefan Agner wrote: > On 2015-03-02 13:59, Uwe Kleine-König wrote: > > On Mon, Mar 02, 2015 at 07:45:17PM +0800, Shawn Guo wrote: > >> On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote: > >> > Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs > >> > the values in struct imx_pin_reg to be -1. This has been done in a > >> > rather unorthodox way by setting the memory to 0xff using memset... > >> > Use a proper for loop to initialize the whole array with -1. > >> > > >> > Signed-off-by: Stefan Agner > >> > >> Acked-by: Shawn Guo > > too late. This patch is part of 4.0-rc1 (4ff0f034e95d). > > This is not the same patch. The patch you are mentioning is actually > fixing a bug introduce in the change where we set -1 for uninitialized > pins. This patch is solving the weird assignment of the initial value... ah right. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |