From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755503AbbCBQLn (ORCPT ); Mon, 2 Mar 2015 11:11:43 -0500 Received: from pmta2.delivery6.ore.mailhop.org ([54.200.129.228]:42344 "EHLO pmta2.delivery6.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753759AbbCBQLd (ORCPT ); Mon, 2 Mar 2015 11:11:33 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+zVLoIIgyOFlwYIK5nEyIO Date: Mon, 2 Mar 2015 08:05:59 -0800 From: Tony Lindgren To: Valentin Rothberg Cc: ssantosh@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] omap_l3_smx.c: remove IRQF_DISABLED flag Message-ID: <20150302160559.GA3756@atomide.com> References: <1425303353-32283-1-git-send-email-Valentin.Rothberg@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425303353-32283-1-git-send-email-Valentin.Rothberg@lip6.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Valentin Rothberg [150302 05:39]: > The IRQF_DISABLED flag is a NOOP and scheduled to be removed. According > to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts > disabled") running IRQ handlers with interrupts enabled can cause stack > overflows when the interrupt line of the issuing device is still active. > > Signed-off-by: Valentin Rothberg Applying into omap-for-v4.1/l3 thanks. Regards, Tony > --- > drivers/bus/omap_l3_smx.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c > index 597fdae..360a5c0 100644 > --- a/drivers/bus/omap_l3_smx.c > +++ b/drivers/bus/omap_l3_smx.c > @@ -251,18 +251,16 @@ static int omap3_l3_probe(struct platform_device *pdev) > } > > l3->debug_irq = platform_get_irq(pdev, 0); > - ret = request_irq(l3->debug_irq, omap3_l3_app_irq, > - IRQF_DISABLED | IRQF_TRIGGER_RISING, > - "l3-debug-irq", l3); > + ret = request_irq(l3->debug_irq, omap3_l3_app_irq, IRQF_TRIGGER_RISING, > + "l3-debug-irq", l3); > if (ret) { > dev_err(&pdev->dev, "couldn't request debug irq\n"); > goto err1; > } > > l3->app_irq = platform_get_irq(pdev, 1); > - ret = request_irq(l3->app_irq, omap3_l3_app_irq, > - IRQF_DISABLED | IRQF_TRIGGER_RISING, > - "l3-app-irq", l3); > + ret = request_irq(l3->app_irq, omap3_l3_app_irq, IRQF_TRIGGER_RISING, > + "l3-app-irq", l3); > if (ret) { > dev_err(&pdev->dev, "couldn't request app irq\n"); > goto err2; > -- > 1.9.1 >