From: Tony Lindgren <tony@atomide.com>
To: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Cc: nm@ti.com, santosh.shilimkar@ti.com, peter.ujfalusi@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omap_l3_noc.c: remove IRQF_DISABLED flag
Date: Mon, 2 Mar 2015 08:06:18 -0800 [thread overview]
Message-ID: <20150302160617.GB3756@atomide.com> (raw)
In-Reply-To: <1425304834-5393-1-git-send-email-Valentin.Rothberg@lip6.fr>
* Valentin Rothberg <Valentin.Rothberg@lip6.fr> [150302 06:04]:
> The IRQF_DISABLED flag is a NOOP and scheduled to be removed. According
> to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts
> disabled") running IRQ handlers with interrupts enabled can cause stack
> overflows when the interrupt line of the issuing device is still active.
>
> Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Applying into omap-for-v4.1/l3 thanks.
Tony
> drivers/bus/omap_l3_noc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
> index 029bc73..11f7982 100644
> --- a/drivers/bus/omap_l3_noc.c
> +++ b/drivers/bus/omap_l3_noc.c
> @@ -284,7 +284,7 @@ static int omap_l3_probe(struct platform_device *pdev)
> */
> l3->debug_irq = platform_get_irq(pdev, 0);
> ret = devm_request_irq(l3->dev, l3->debug_irq, l3_interrupt_handler,
> - IRQF_DISABLED, "l3-dbg-irq", l3);
> + 0x0, "l3-dbg-irq", l3);
> if (ret) {
> dev_err(l3->dev, "request_irq failed for %d\n",
> l3->debug_irq);
> @@ -293,7 +293,7 @@ static int omap_l3_probe(struct platform_device *pdev)
>
> l3->app_irq = platform_get_irq(pdev, 1);
> ret = devm_request_irq(l3->dev, l3->app_irq, l3_interrupt_handler,
> - IRQF_DISABLED, "l3-app-irq", l3);
> + 0x0, "l3-app-irq", l3);
> if (ret)
> dev_err(l3->dev, "request_irq failed for %d\n", l3->app_irq);
>
> --
> 1.9.1
>
prev parent reply other threads:[~2015-03-02 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 14:00 [PATCH] omap_l3_noc.c: remove IRQF_DISABLED flag Valentin Rothberg
2015-03-02 16:06 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302160617.GB3756@atomide.com \
--to=tony@atomide.com \
--cc=Valentin.Rothberg@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox