* [PATCH] omap_l3_noc.c: remove IRQF_DISABLED flag
@ 2015-03-02 14:00 Valentin Rothberg
2015-03-02 16:06 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Valentin Rothberg @ 2015-03-02 14:00 UTC (permalink / raw)
To: nm, santosh.shilimkar, peter.ujfalusi, tony, linux-kernel
Cc: Valentin Rothberg
The IRQF_DISABLED flag is a NOOP and scheduled to be removed. According
to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts
disabled") running IRQ handlers with interrupts enabled can cause stack
overflows when the interrupt line of the issuing device is still active.
Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
---
drivers/bus/omap_l3_noc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index 029bc73..11f7982 100644
--- a/drivers/bus/omap_l3_noc.c
+++ b/drivers/bus/omap_l3_noc.c
@@ -284,7 +284,7 @@ static int omap_l3_probe(struct platform_device *pdev)
*/
l3->debug_irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(l3->dev, l3->debug_irq, l3_interrupt_handler,
- IRQF_DISABLED, "l3-dbg-irq", l3);
+ 0x0, "l3-dbg-irq", l3);
if (ret) {
dev_err(l3->dev, "request_irq failed for %d\n",
l3->debug_irq);
@@ -293,7 +293,7 @@ static int omap_l3_probe(struct platform_device *pdev)
l3->app_irq = platform_get_irq(pdev, 1);
ret = devm_request_irq(l3->dev, l3->app_irq, l3_interrupt_handler,
- IRQF_DISABLED, "l3-app-irq", l3);
+ 0x0, "l3-app-irq", l3);
if (ret)
dev_err(l3->dev, "request_irq failed for %d\n", l3->app_irq);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] omap_l3_noc.c: remove IRQF_DISABLED flag
2015-03-02 14:00 [PATCH] omap_l3_noc.c: remove IRQF_DISABLED flag Valentin Rothberg
@ 2015-03-02 16:06 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2015-03-02 16:06 UTC (permalink / raw)
To: Valentin Rothberg; +Cc: nm, santosh.shilimkar, peter.ujfalusi, linux-kernel
* Valentin Rothberg <Valentin.Rothberg@lip6.fr> [150302 06:04]:
> The IRQF_DISABLED flag is a NOOP and scheduled to be removed. According
> to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts
> disabled") running IRQ handlers with interrupts enabled can cause stack
> overflows when the interrupt line of the issuing device is still active.
>
> Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Applying into omap-for-v4.1/l3 thanks.
Tony
> drivers/bus/omap_l3_noc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
> index 029bc73..11f7982 100644
> --- a/drivers/bus/omap_l3_noc.c
> +++ b/drivers/bus/omap_l3_noc.c
> @@ -284,7 +284,7 @@ static int omap_l3_probe(struct platform_device *pdev)
> */
> l3->debug_irq = platform_get_irq(pdev, 0);
> ret = devm_request_irq(l3->dev, l3->debug_irq, l3_interrupt_handler,
> - IRQF_DISABLED, "l3-dbg-irq", l3);
> + 0x0, "l3-dbg-irq", l3);
> if (ret) {
> dev_err(l3->dev, "request_irq failed for %d\n",
> l3->debug_irq);
> @@ -293,7 +293,7 @@ static int omap_l3_probe(struct platform_device *pdev)
>
> l3->app_irq = platform_get_irq(pdev, 1);
> ret = devm_request_irq(l3->dev, l3->app_irq, l3_interrupt_handler,
> - IRQF_DISABLED, "l3-app-irq", l3);
> + 0x0, "l3-app-irq", l3);
> if (ret)
> dev_err(l3->dev, "request_irq failed for %d\n", l3->app_irq);
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-02 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-02 14:00 [PATCH] omap_l3_noc.c: remove IRQF_DISABLED flag Valentin Rothberg
2015-03-02 16:06 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox