From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755549AbbCBQLx (ORCPT ); Mon, 2 Mar 2015 11:11:53 -0500 Received: from pmta1.delivery3.ore.mailhop.org ([54.191.214.36]:39260 "EHLO pmta1.delivery3.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbbCBQLv (ORCPT ); Mon, 2 Mar 2015 11:11:51 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1/sxyVeg+R/ExuGscTaPxd7 Date: Mon, 2 Mar 2015 08:06:18 -0800 From: Tony Lindgren To: Valentin Rothberg Cc: nm@ti.com, santosh.shilimkar@ti.com, peter.ujfalusi@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] omap_l3_noc.c: remove IRQF_DISABLED flag Message-ID: <20150302160617.GB3756@atomide.com> References: <1425304834-5393-1-git-send-email-Valentin.Rothberg@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425304834-5393-1-git-send-email-Valentin.Rothberg@lip6.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Valentin Rothberg [150302 06:04]: > The IRQF_DISABLED flag is a NOOP and scheduled to be removed. According > to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts > disabled") running IRQ handlers with interrupts enabled can cause stack > overflows when the interrupt line of the issuing device is still active. > > Signed-off-by: Valentin Rothberg Applying into omap-for-v4.1/l3 thanks. Tony > drivers/bus/omap_l3_noc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c > index 029bc73..11f7982 100644 > --- a/drivers/bus/omap_l3_noc.c > +++ b/drivers/bus/omap_l3_noc.c > @@ -284,7 +284,7 @@ static int omap_l3_probe(struct platform_device *pdev) > */ > l3->debug_irq = platform_get_irq(pdev, 0); > ret = devm_request_irq(l3->dev, l3->debug_irq, l3_interrupt_handler, > - IRQF_DISABLED, "l3-dbg-irq", l3); > + 0x0, "l3-dbg-irq", l3); > if (ret) { > dev_err(l3->dev, "request_irq failed for %d\n", > l3->debug_irq); > @@ -293,7 +293,7 @@ static int omap_l3_probe(struct platform_device *pdev) > > l3->app_irq = platform_get_irq(pdev, 1); > ret = devm_request_irq(l3->dev, l3->app_irq, l3_interrupt_handler, > - IRQF_DISABLED, "l3-app-irq", l3); > + 0x0, "l3-app-irq", l3); > if (ret) > dev_err(l3->dev, "request_irq failed for %d\n", l3->app_irq); > > -- > 1.9.1 >