From: Javi Merino <javi.merino@arm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "acme@redhat.com" <acme@redhat.com>,
"jolsa@redhat.com" <jolsa@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v6 1/2] tools lib traceevent: factor out allocating and processing args
Date: Mon, 2 Mar 2015 17:30:53 +0000 [thread overview]
Message-ID: <20150302173052.GA15351@e104805> (raw)
In-Reply-To: <20150227103841.0e9f55d8@gandalf.local.home>
On Fri, Feb 27, 2015 at 03:38:41PM +0000, Steven Rostedt wrote:
> On Fri, 27 Feb 2015 14:48:14 +0000
> Javi Merino <javi.merino@arm.com> wrote:
>
>
> > +static int alloc_and_process_arg(struct event_format *event, char *next_token,
> > + struct print_arg **print_arg)
> > +{
> > + struct print_arg *field;
> > + enum event_type type;
> > + char *token;
> > + int ret = 0;
> > +
> > + field = alloc_arg();
> > + if (!field) {
> > + do_warning_event(event, "%s: not enough memory!", __func__);
> > + errno = ENOMEM;
> > + return -1;
> > + }
> > +
> > + type = process_arg(event, field, &token);
> > +
> > + if (test_type_token(type, token, EVENT_DELIM, next_token)) {
>
> I wonder if we should call this "alloc_and_process_delim()", as this
> isn't a generic arg, but only used for deliminators.
Ok, I'll send a v7 renaming this function.
Cheers,
Javi
next prev parent reply other threads:[~2015-03-02 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 14:48 [PATCH v6 0/2] Add array printing support to libtraceevent Javi Merino
2015-02-27 14:48 ` [PATCH v6 1/2] tools lib traceevent: factor out allocating and processing args Javi Merino
2015-02-27 15:38 ` Steven Rostedt
2015-03-02 17:30 ` Javi Merino [this message]
2015-02-27 14:48 ` [PATCH v6 2/2] tools lib traceevent: Add support for __print_array() Javi Merino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302173052.GA15351@e104805 \
--to=javi.merino@arm.com \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox