From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754908AbbCBTKz (ORCPT ); Mon, 2 Mar 2015 14:10:55 -0500 Received: from mail-qg0-f48.google.com ([209.85.192.48]:59274 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753705AbbCBTKx (ORCPT ); Mon, 2 Mar 2015 14:10:53 -0500 Date: Mon, 2 Mar 2015 14:10:49 -0500 From: Tejun Heo To: Alexander Gordeev Cc: Stefan Bader , Sander Eikelenboom , linux-kernel@vger.kernel.org Subject: Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "" Message-ID: <20150302191049.GA8051@htj.duckdns.org> References: <534449189.20150209205457@eikelenboom.it> <54D9B9FA.9030900@canonical.com> <20150210145120.GI3220@htj.duckdns.org> <20150216172841.GA23072@agordeev.usersys.redhat.com> <20150302172108.GN17694@htj.duckdns.org> <20150302185809.GA23808@agordeev.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150302185809.GA23808@agordeev.usersys.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2015 at 06:58:10PM +0000, Alexander Gordeev wrote: > On Mon, Mar 02, 2015 at 12:21:08PM -0500, Tejun Heo wrote: > > Hello, > > > > On Mon, Feb 16, 2015 at 05:28:42PM +0000, Alexander Gordeev wrote: > > > The problem dates back to commit 4f37b50 ("libata: Use dev_name() for > > > request_irq() to distinguish devices"). If the commit is considered valid > > > then still might be legitimate as well. Not sure what is the best > > > approach here. > > > > What does indicate? Does it successfully identify the device in > > question? > > I suppose, PCI bus-device-function. > Yes, it does. Hmmm... it does stand out like a sore thumb and we probably should use a more descriptive identifier including the driver name. 4f37b50 ("libata: Use dev_name() was fine for the specific platform device as the device identifier included ide but not generally. :( How about driver name followed by device ID? Thanks. -- tejun