From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755029AbbCBTV0 (ORCPT ); Mon, 2 Mar 2015 14:21:26 -0500 Received: from mail-lb0-f181.google.com ([209.85.217.181]:39613 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754949AbbCBTVY (ORCPT ); Mon, 2 Mar 2015 14:21:24 -0500 From: Andrey Skvortsov X-Google-Original-From: Andrey Skvortsov Date: Mon, 2 Mar 2015 22:21:20 +0300 To: Joe Perches Cc: Dan Carpenter , devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, Matteo Semenzato , noralf@tronnes.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: fbtft: fix space errors Message-ID: <20150302192120.GA4136@nest> Mail-Followup-To: Andrey Skvortsov , Joe Perches , Dan Carpenter , devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, Matteo Semenzato , noralf@tronnes.org, linux-kernel@vger.kernel.org References: <1425134695-10280-1-git-send-email-mattew8898@gmail.com> <1425135559.25697.2.camel@perches.com> <20150302093704.GE5386@mwanda> <1425306048.31561.16.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline In-Reply-To: <1425306048.31561.16.camel@perches.com> X-PGP-Key: fp="21AF 2E6F 04EC 7E11 21C6 E399 2236 2F26 57A3 AEAD"; id="0x57A3AEAD"; get=; User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 02 Mar, Joe Perches wrote: > On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote: > > On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote: > > > If you're really going to change these, please > > > remove the unnecessary \ line continuations > > > indent the blocks properly and group the blocks > > > more intelligibly. Maybe something like; > > >=20 > > > static const int st7735r_init[] =3D {=20 > > > -1, 0x01, > [] > > > -2, 10, > > > -3 > > > }; > >=20 > > What's the logic here? Why are we putting the negatives first? >=20 > Those are delimiters. see fbtft-core.c:fbtft_init_display(). >=20 > As far as I understand: >=20 > -1, start of block > -2, millisecond delay after block write > -3, end of blocks >=20 > Beyond that, I don't much care. > I just prefer intelligible over apparently random. If it is correct, then it would be better to replace these magic numbers wi= th meaningful defines. --=20 Best regards, Andrey Skvortsov --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJU9LgwAAoJEAF8y6L1SLCtNJMP/1x5wJmbeDRFXpBxb2Wg+EAa rrah+F4heUO6V3zzsWPjJHjZ94UjFmS0qx/cZ9HxRekPc2amBgY0HsmY/j/69X66 V2fWF2OMv2DKihJEtfZZRqdOtGD84MiSAqnTHWiPhz2WIcwo+APST7GbSBlQP7Ah /0TDDoRl4NHvUwtHnUEWBcOLCKAuMmoT6aSEJ1xIqWcJmMJcJPNcLSnuI9DnN65v DfBWFPuyv4icqOJpz6okEi2eDN4XW7ghDDpfa+W/f6ybGyjBICW1klazcVxsaCup cuGv4mMkb57D17BxocF356G4pWqyj7/TWO2olOYbZUiQ8I2govz0BGE5PuH1G9G7 hWigBsHG1orGntHDWUX4ZAFIht7fNgttu6QChcvE1ScWGKZt3UrL4UlVWDthVJlf 7bqXiM/Hvh5cq6uZ4E6H9BnaJBJUdvLpz2sxe0YAJT+HVt6Q9k99lZ/+QemgBbB7 U+iiRaWOqlKXGWyB+IxWj0iyGR2Q3otWnjtmQTebYakivLnlDuvJXR4cUraNV3oM 9IjvvmuouYSFjat0LOgVXvr7qE/PuKTuWcGCyWM8J3KkNCXi0MCKHd2M4IRTDVY6 kbDLQyp4IruRFvhw4nnMFHN4OMgIJXnROz1uqY3UD79M7zia2ucE0l8U6t60nE9M AHu3DUHIsaEU03q2ay1A =Ynb9 -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--