Re: [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

Pavel Machek
2015-03-04T10:17:44Z

Hi!

> > New /sys files should be documented somewhere...?
>
> Preferably with the code...
>
> > Does it make sense to change "440k" -> "440KOhm"?
>
> Interesting question. I prefer to avoid including units in files - bare
> numbers is better. But there is no number to match "floating" unless I spell
> it out as "infinity", and wouldn't be helpful.
>
> Certainly "K" would be preferred over "k", and given that I have "ground"
> and "floating", it is more consistent to include the "Ohm"....
>
> These are really names, not measures of resistance. The data sheet calls
> them:
> ID_RES_FLOAT (or sometimes ID_FLOAT)
> ID_RES_440K
> ID_RES_200K
> ID_RES_102K
> ID_GND (or sometimes ID_RES_GND)
>
> So using those names is defensible.
>
> I think I'll change them all to upper case, but leave out the "Ohm".
> My justification is consistency with the data sheet.

Does it make sense to use "_ohm" in the attribute name, then? (And
yes, I was wrong with the "K", "k" is actually right.)

> > Plus I guess you need to update Documentation/
>
> I guess I'll need to give in to this eventually :-)

Yes please. It was useful in past.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html