Re: [PATCH 2/4] usb: phy: twl4030: allow charger to see usb current draw limits.

NeilBrown
2015-03-04T06:18:02Z

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

On Mon, 2 Mar 2015 22:03:55 +0100 Pavel Machek <pavel@ucw.cz> wrote:

> On Tue 2015-02-24 14:40:37, NeilBrown wrote:
> > The charger needs to know when a USB gadget has been enumerated
> > and what the agreed maximum current was so that it can adjust
> > charging accordingly.
> >
> > So define a "set_power()" function to record the permitted
> > draw, and pass a pointer to that when sending USB_EVENT_ENUMERATED
> > notification.
> >
> > Signed-off-by: NeilBrown <neilb@suse.de>
> > ---
> > drivers/phy/phy-twl4030-usb.c | 27 +++++++++++++++++++++------
> > 1 file changed, 21 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
> > index 97c59074233f..023fe150c7a1 100644
> > --- a/drivers/phy/phy-twl4030-usb.c
> > +++ b/drivers/phy/phy-twl4030-usb.c
> > @@ -163,6 +163,11 @@ struct twl4030_usb {
> > enum omap_musb_vbus_id_status linkstat;
> > bool vbus_supplied;
> >
> > + /* Permitted vbus draw - only meaningful after
>
> add "in mA"?
>
> > + * USB_EVENT_ENUMERATED
> > + */
> > + unsigned vbus_draw;
> > +
> > struct delayed_work id_workaround_work;
>

Yes. I make it 'unsigned int' too.

Thanks,
NeilBrown

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]