From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jeff Epler <jepler@unpythonic.net>
Cc: linux-input@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: psmouse - when comparing PNP IDs ignore case
Date: Mon, 2 Mar 2015 14:19:47 -0800 [thread overview]
Message-ID: <20150302221947.GA30717@dtor-glaptop> (raw)
In-Reply-To: <20150302221435.GA668@unpythonic.net>
Hi Jeff,
On Mon, Mar 02, 2015 at 04:14:37PM -0600, Jeff Epler wrote:
> On Fri, Feb 27, 2015 at 04:18:52PM -0800, Dmitry Torokhov wrote:
> > PNP IDs are supposed to be case-insensitive and so we should compare
> > them as such.
>
> Have specific systems popped up which need this fix, or is it just in
> the interests of being correct? If there are specific system(s) that
> are affected, it would be valuable to list them or at least say so.
It is needed by another patch identifying SYN300D as a forcepad whereas in
BIOS it is actually SYN300d. While we could change the kernel to match against
SYN300d I am not sure if somebody else won't use SYN300D in some other BIOS.
Thanks.
--
Dmitry
prev parent reply other threads:[~2015-03-02 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 0:18 [PATCH] Input: psmouse - when comparing PNP IDs ignore case Dmitry Torokhov
2015-02-28 10:15 ` Hans de Goede
2015-03-02 22:14 ` Jeff Epler
2015-03-02 22:19 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302221947.GA30717@dtor-glaptop \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=jepler@unpythonic.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox