From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756713AbbCCT0F (ORCPT ); Tue, 3 Mar 2015 14:26:05 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:36534 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752278AbbCCT0D (ORCPT ); Tue, 3 Mar 2015 14:26:03 -0500 Date: Tue, 03 Mar 2015 14:26:01 -0500 (EST) Message-Id: <20150303.142601.473683335714577293.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code From: David Miller In-Reply-To: <1425408125.5130.191.camel@edumazet-glaptop2.roam.corp.google.com> References: <1425388752.5130.164.camel@edumazet-glaptop2.roam.corp.google.com> <1425407104.17273.27.camel@perches.com> <1425408125.5130.191.camel@edumazet-glaptop2.roam.corp.google.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Mar 2015 11:26:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Tue, 03 Mar 2015 10:42:05 -0800 > On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote: > >> At least for arm gcc 4.6.3, it emits different code >> for net/l2tp/l2tp_eth.o > > Then it looks like arm gcc or arm linux memset() should be improved. > > Tracking all memset(x, y, 6) and replace them by some custom version > seems not very generic to me, when something better can be done. +1, and none of this stuff is on the fast path anyways. I think I'll skip this series fornow.