From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754771AbbCCAKU (ORCPT ); Mon, 2 Mar 2015 19:10:20 -0500 Received: from pmta1.delivery3.ore.mailhop.org ([54.191.214.36]:57839 "EHLO pmta1.delivery3.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753832AbbCCAKS (ORCPT ); Mon, 2 Mar 2015 19:10:18 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX19wCHD8LXSjOxV50VHq1NyP Date: Mon, 2 Mar 2015 16:04:45 -0800 From: Tony Lindgren To: Murali Karicheri Cc: davem@davemloft.net, mugunthanvnm@ti.com, prabhakar.csengg@gmail.com, varkabhadram@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, grygorii.strashko@ti.com, lokeshvutla@ti.com, mpa@pengutronix.de, w-kwok2@ti.com Subject: Re: [PATCH net-next 2/2] net: netcp: select davinci_mdio driver by default Message-ID: <20150303000444.GC3756@atomide.com> References: <1424813251-31610-1-git-send-email-m-karicheri2@ti.com> <1424813251-31610-2-git-send-email-m-karicheri2@ti.com> <20150227162921.GX11056@atomide.com> <54F0D9E9.1020705@ti.com> <20150302161155.GB3665@atomide.com> <54F4DA06.9070505@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54F4DA06.9070505@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Murali Karicheri [150302 13:49]: > On 03/02/2015 11:11 AM, Tony Lindgren wrote: > > > >Because we are now force selecting items that may have other > >dependencies later on that will not be satisfied. That causes > >all kinds of make randconfig build errors. > > > My mistake. I didn't ask you what is your definition of a silent option? An > option not selected by any other option? Or an option for which default > value not defined? Can you clarify this so that I can make sense of your > comment? I checked Documentation/kbuild/kconfig.txt as well as > Documentation/kbuild/kconfig-language.txt for defintion, but can't find it. > > Howeve, I read the warning about using "select" in the above document since > it blindly select the option without checking dependencies. So AFAIK, select > becomes an issue if the config option is not the leaf option of the config > tree as the dependency checking is not in place and can cause issues. In > this case it is safe as DAVINCI_MDIO is a leaf option and only selects > PHYLIB which dependents on NETDEVICES and we know this is true for NETCP > devices. So select is just fine here. OK I think you're right that in this case it won't cause issues. But if these cpsw components are never selectable by the user for any real use case, then you may want to make them silent Kconfig options: config TI_DAVINCI_MDIO bool select PHYLIB config TI_DAVINCI_CPDMA bool config TI_CPSW_PHY_SEL bool config TI_CPSW_ALE bool ... Regards, Tony