From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Cláudio Maia" <crrm@isep.ipp.pt>
Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings
Date: Tue, 3 Mar 2015 09:35:50 +0300 [thread overview]
Message-ID: <20150303063550.GJ5386@mwanda> (raw)
In-Reply-To: <1425353777-19494-1-git-send-email-crrm@isep.ipp.pt>
On Tue, Mar 03, 2015 at 03:36:17AM +0000, Cláudio Maia wrote:
> The following errors were fixed:
>
> ERROR: code indent should use tabs where possible
> WARNING: line over 80 characters
>
> Signed-off-by: Cláudio Maia <crrm@isep.ipp.pt>
Don't indent this.
> @@ -52,60 +52,63 @@ static int init_display(struct fbtft_par *par)
> par->fbtftops.reset(par);
>
> /* Function set */
> - write_reg(par, 0x21); /* 5:1 1
> - 2:0 PD - Powerdown control: chip is active
> - 1:0 V - Entry mode: horizontal addressing
> - 0:1 H - Extended instruction set control: extended
> - */
> + write_reg(par, 0x21); /*
> + 5:1 1
> + 2:0 PD - Powerdown control: chip is active
> + 1:0 V - Entry mode: horizontal addressing
> + 0:1 H - Extended instruction set control: extended
> + */
This looks kind of weird and this is not kernel style for commenting.
Read Documentation/CodingStyle.
regards,
dan carpenter
prev parent reply other threads:[~2015-03-03 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 3:36 [PATCH] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings Cláudio Maia
2015-03-03 6:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303063550.GJ5386@mwanda \
--to=dan.carpenter@oracle.com \
--cc=crrm@isep.ipp.pt \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox