From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753150AbbCCGgS (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Mar 2015 01:36:18 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:28009 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752042AbbCCGgR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Mar 2015 01:36:17 -0500
Date: Tue, 3 Mar 2015 09:35:50 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: =?iso-8859-1?Q?Cl=E1udio?= Maia <crrm@isep.ipp.pt>
Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: fbtft: fb_pcd8544: Fixed coding style errors
 and warnings
Message-ID: <20150303063550.GJ5386@mwanda>
References: <1425353777-19494-1-git-send-email-crrm@isep.ipp.pt>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1425353777-19494-1-git-send-email-crrm@isep.ipp.pt>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 03, 2015 at 03:36:17AM +0000, Cláudio Maia wrote:
>     The following errors were fixed:
> 
>     ERROR: code indent should use tabs where possible
>     WARNING: line over 80 characters
> 
>     Signed-off-by: Cláudio Maia <crrm@isep.ipp.pt>

Don't indent this.

> @@ -52,60 +52,63 @@ static int init_display(struct fbtft_par *par)
>  	par->fbtftops.reset(par);
>  
>  	/* Function set */
> -	write_reg(par, 0x21); /* 5:1  1
> -	                         2:0  PD - Powerdown control: chip is active
> -							 1:0  V  - Entry mode: horizontal addressing
> -							 0:1  H  - Extended instruction set control: extended
> -						  */
> +	write_reg(par, 0x21); /*
> +			5:1  1
> +			2:0  PD - Powerdown control: chip is active
> +			1:0  V  - Entry mode: horizontal addressing
> +			0:1  H  - Extended instruction set control: extended
> +			*/

This looks kind of weird and this is not kernel style for commenting.
Read Documentation/CodingStyle.

regards,
dan carpenter