From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755973AbbCCKUU (ORCPT ); Tue, 3 Mar 2015 05:20:20 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:40758 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbbCCKUS (ORCPT ); Tue, 3 Mar 2015 05:20:18 -0500 Date: Tue, 3 Mar 2015 04:19:17 -0600 From: Drew Fustini To: Thomas Petazzoni , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] Staging: fbtft: move externs to header file Message-ID: <20150303101917.GA20306@lappy486> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move extern declartions from fbtft-core.c to fbtft header file. This resovles the warning from checkpatch.pl that "externs should be avoided in .c files". Signed-off-by: Drew Fustini --- drivers/staging/fbtft/fbtft-core.c | 5 ----- drivers/staging/fbtft/fbtft.h | 7 +++++++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index ac4287f..3422faf 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -42,11 +42,6 @@ #include "fbtft.h" -extern void fbtft_sysfs_init(struct fbtft_par *par); -extern void fbtft_sysfs_exit(struct fbtft_par *par); -extern void fbtft_expand_debug_value(unsigned long *debug); -extern int fbtft_gamma_parse_str(struct fbtft_par *par, unsigned long *curves, - const char *str, int size); static unsigned long debug; module_param(debug, ulong, 0); diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 0dbf3f9..9e729e5 100644 --- a/drivers/staging/fbtft/fbtft.h +++ b/drivers/staging/fbtft/fbtft.h @@ -277,6 +277,13 @@ extern int fbtft_init_display(struct fbtft_par *par); extern int fbtft_probe_common(struct fbtft_display *display, struct spi_device *sdev, struct platform_device *pdev); extern int fbtft_remove_common(struct device *dev, struct fb_info *info); +extern void fbtft_sysfs_init(struct fbtft_par *par); +extern void fbtft_sysfs_exit(struct fbtft_par *par); +extern void fbtft_expand_debug_value(unsigned long *debug); +extern int fbtft_gamma_parse_str(struct fbtft_par *par, unsigned long *curves, + const char *str, int size); + + /* fbtft-io.c */ extern int fbtft_write_spi(struct fbtft_par *par, void *buf, size_t len); -- 2.1.4