From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Drew Fustini <pdp7pdp7@gmail.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: fbtft: move externs to header file
Date: Tue, 3 Mar 2015 16:33:01 +0530 [thread overview]
Message-ID: <20150303110301.GA2228@sudip-PC> (raw)
In-Reply-To: <20150303101917.GA20306@lappy486>
On Tue, Mar 03, 2015 at 04:19:17AM -0600, Drew Fustini wrote:
> Move extern declartions from fbtft-core.c to fbtft header file. This resovles
> the warning from checkpatch.pl that "externs should be avoided in .c files".
but now it adds 6 additional warning in checkpatch --strict
"extern prototypes should be avoided in .h files"
regards
sudip
>
> Signed-off-by: Drew Fustini <pdp7pdp7@gmail.com>
> ---
next prev parent reply other threads:[~2015-03-03 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 10:19 [PATCH] Staging: fbtft: move externs to header file Drew Fustini
2015-03-03 11:03 ` Sudip Mukherjee [this message]
2015-03-03 18:52 ` Drew Fustini
2015-03-03 19:04 ` Noralf Trønnes
2015-03-04 8:12 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303110301.GA2228@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=pdp7pdp7@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox