From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757225AbbCCWuf (ORCPT ); Tue, 3 Mar 2015 17:50:35 -0500 Received: from mx-guillaumet.finsecur.com ([91.217.234.131]:43043 "EHLO guillaumet.finsecur.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756031AbbCCWue (ORCPT ); Tue, 3 Mar 2015 17:50:34 -0500 Date: Tue, 3 Mar 2015 23:50:24 +0100 From: Sylvain Rochet To: Nicolas Ferre Cc: Wenyou Yang , linux@maxim.org.za, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, peda@axentia.se Message-ID: <20150303225024.GA28292@gradator.net> References: <1423115977-5852-1-git-send-email-wenyou.yang@atmel.com> <1423116083-5986-1-git-send-email-wenyou.yang@atmel.com> <54F60092.5070902@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54F60092.5070902@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 172.16.8.13 X-SA-Exim-Mail-From: sylvain.rochet@finsecur.com Subject: Re: [PATCH 2/3] pm: at91: pm_slowclock: remove clocks which are already stopped when entering slow clock mode X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on guillaumet.finsecur.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Nicolas, On Tue, Mar 03, 2015 at 07:42:26PM +0100, Nicolas Ferre wrote: > Le 05/02/2015 07:01, Wenyou Yang a écrit : > > From: Sylvain Rochet > > > > Assume USB PLL and PLL B are already stopped before entering sleep mode, > > print a warning if this isn't the case. > > > > Removed PLL B from slow clock code, all drivers are supposed to properly > > unprepare clocks. > > > > Signed-off-by: Sylvain Rochet > > Acked-by: Wenyou.Yang > > I keep this one for 4.1 as all the USB drivers are not converted yet. I agree we should wait to prevent a regression, in case you missed that I sent a v7 of my USBA PM support a few weeks ago (ping ;-). Sylvain