From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 2/8] zram: use idr instead of `zram_devices' array
Date: Wed, 4 Mar 2015 09:21:12 +0900 [thread overview]
Message-ID: <20150304002112.GB1864@swordfish> (raw)
In-Reply-To: <20150303140141.9adbb3dae4253130aad5d16b@linux-foundation.org>
On (03/03/15 14:01), Andrew Morton wrote:
> > This patch makes some preparations for dynamic device ADD/REMOVE functionality
> > via /dev/zram-control interface.
> >
> > Remove `zram_devices' array and switch to id-to-pointer translation (idr).
> > idr doesn't bloat zram struct with additional members, f.e. list_head, yet
> > still provides ability to match the device_id with the device pointer.
> > No user-space visible changes.
> >
> > ...
> >
> > +static DEFINE_IDR(zram_index_idr);
>
> There is no locking protecting this idr?
>
correct. there is no concurrent idr index modification at this point.
add/remove functionality and concurrent idr modification will be intoriduced
in the patch 0005 zram add dynamic device add remove functionality (along
with `static DEFINE_MUTEX(zram_index_mutex)' idr protection).
-ss
next prev parent reply other threads:[~2015-03-04 0:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 12:49 [PATCHv3 0/8] introduce dynamic device creation/removal Sergey Senozhatsky
2015-03-03 12:49 ` [PATCH 1/8] zram: cosmetic ZRAM_ATTR_RO code formatting tweak Sergey Senozhatsky
2015-03-03 12:49 ` [PATCH 2/8] zram: use idr instead of `zram_devices' array Sergey Senozhatsky
2015-03-03 22:01 ` Andrew Morton
2015-03-04 0:21 ` Sergey Senozhatsky [this message]
2015-03-04 7:06 ` Minchan Kim
2015-03-04 7:34 ` Sergey Senozhatsky
2015-03-04 7:49 ` Sergey Senozhatsky
2015-03-05 0:59 ` Minchan Kim
2015-03-03 12:49 ` [PATCH 3/8] zram: factor out device reset from reset_store() Sergey Senozhatsky
2015-03-05 2:28 ` Minchan Kim
2015-03-03 12:49 ` [PATCH 4/8] zram: reorganize code layout Sergey Senozhatsky
2015-03-03 12:49 ` [PATCH 5/8] zram: add dynamic device add/remove functionality Sergey Senozhatsky
2015-03-03 22:01 ` Andrew Morton
2015-03-04 0:18 ` Sergey Senozhatsky
2015-03-04 7:10 ` Minchan Kim
2015-03-04 7:29 ` Sergey Senozhatsky
2015-03-04 8:19 ` Sergey Senozhatsky
2015-03-04 8:36 ` Sergey Senozhatsky
2015-03-03 12:49 ` [PATCH 6/8] zram: remove max_num_devices limitation Sergey Senozhatsky
2015-03-03 12:49 ` [PATCH 7/8] zram: report every added and removed device Sergey Senozhatsky
2015-03-03 12:49 ` [PATCH 8/8] zram: trivial: correct flag operations comment Sergey Senozhatsky
2015-04-15 21:37 ` [PATCHv3 0/8] introduce dynamic device creation/removal Andrew Morton
2015-04-15 23:40 ` Minchan Kim
2015-04-16 0:30 ` Sergey Senozhatsky
2015-04-16 0:47 ` Sergey Senozhatsky
-- strict thread matches above, loose matches on Subject: below --
2015-02-26 14:10 [PATCH " Sergey Senozhatsky
2015-02-26 14:10 ` [PATCH 2/8] zram: use idr instead of `zram_devices' array Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304002112.GB1864@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox