From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755564AbbCDCEf (ORCPT ); Tue, 3 Mar 2015 21:04:35 -0500 Received: from mail-by2on0143.outbound.protection.outlook.com ([207.46.100.143]:50720 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752805AbbCDCEd (ORCPT ); Tue, 3 Mar 2015 21:04:33 -0500 Date: Wed, 4 Mar 2015 08:51:53 +0800 From: Peter Chen To: Matt Porter CC: Shawn Guo , Sascha Hauer , Devicetree List , Linux ARM Kernel List , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances Message-ID: <20150304005152.GA23399@shlinux2> References: <1425045960-14191-1-git-send-email-mporter@konsulko.com> <20150303034133.GJ20455@dragon> <20150303044334.GA16617@shlinux2> <20150303150809.GD30263@beef> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150303150809.GD30263@beef> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=peter.chen@freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(339900001)(51704005)(24454002)(93886004)(110136001)(33716001)(106466001)(76176999)(54356999)(83506001)(50466002)(85426001)(104016003)(19580405001)(19580395003)(33656002)(105606002)(23726002)(46102003)(77096005)(2950100001)(6806004)(86362001)(97756001)(62966003)(87936001)(77156002)(47776003)(50986999)(92566002)(46406003);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR03MB180;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:sfv;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB180; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006);SRVR:BL2PR03MB180; X-Forefront-PRVS: 0505147DDB X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB180; X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2015 02:04:30.3814 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 03, 2015 at 10:08:09AM -0500, Matt Porter wrote: > On Tue, Mar 03, 2015 at 12:43:36PM +0800, Peter Chen wrote: > > On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote: > > > > > > On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: > > > > The chipidea driver adds an extra line of spam to the log when a > > > > host-only chipidea instance is left set to the default of a dual role > > > > controller. > > > > > > > > [ 2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget > > > > > > > > Set the dr_mode property to host on all the host-only nodes > > > > to avoid this warning. > > > > It is not an warning, it is dev_info. > > True enough, it's info level but is essentially warning that, in the > case of instances that are restricted to host only (at the SoC level), > that the DT hardware description is incorrect. Yes, it's benign, but > if the dtsi is corrected for those parts we don't have to see that > message. You are right. > > > In fact, imx28, imx6sl and imx6sx's second controller is dual-role > > controller, we only set dr_mode at board's dts according to design > > unless the controller's capability register is incorrect. > > The patch doesn't set dr_mode to host on the second controller for > the imx6sl or imx6sx, only on the third host-only controller. If > imx28's second controller is really dual-role capable then the > reference manual is incorrect and I can drop that hunk in v2. > I only have imx6q and imx6d parts in hand to verify so for the rest > I went by the RM claim of which controllers were host-only. Maybe IC guys don't want to export that imx28's that capabilities, so don't need to change. > > > So, sorry, I don't think this change is necessary. > > I can correct the set of instances that should have dr_mode set to host > in v2 of this. We clearly have some that should have this set in their > SoC .dtsi to have the hardware description correct. Will that work for > you or do you want the SoC-specific cases of this property to be only > reflected in the board level dts? > After thinking more, it is a benefit fix, and doesn't need to do any changes, thanks. Acked-by: Peter Chen -- Best Regards, Peter Chen