From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756717AbbCDCF6 (ORCPT ); Tue, 3 Mar 2015 21:05:58 -0500 Received: from mail-pd0-f171.google.com ([209.85.192.171]:41892 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755975AbbCDCF4 (ORCPT ); Tue, 3 Mar 2015 21:05:56 -0500 Date: Wed, 4 Mar 2015 11:05:15 +0900 From: Namhyung Kim To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, Adrian Hunter , Arnaldo Carvalho de Melo , Corey Ashford , David Ahern , Frederic Weisbecker , Ingo Molnar , Paul Mackerras , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH 0/3] perf tools: Adding xz decompression support Message-ID: <20150304020515.GI27046@danjae> References: <1425396581-17716-1-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1425396581-17716-1-git-send-email-jolsa@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 03, 2015 at 04:29:27PM +0100, Jiri Olsa wrote: > hi, > adding support to decompress kernel modules on Fedora 21 > (lzma compression) vaguely continuing in previous RFC: > http://marc.info/?l=linux-kernel&m=142261340327588&w=2 > > I'm basically extending he decompression framework Namhyung > introduced earlier plus other fixes for kernel modules dso > objects handling. > > Last patch adds decompression support to annotate command, so > it now displays annotation for compressed kernel modules. Nice work! I went through the patches and liked the kmod_path__parse change. :) Please feel free to add my Ack's to this series when you send v2. Thanks, Namhyung > > Current work available at: > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > perf/lzma > > thanks, > jirka > > > Signed-off-by: Jiri Olsa > Cc: Adrian Hunter > Cc: Arnaldo Carvalho de Melo > Cc: Corey Ashford > Cc: David Ahern > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra > Cc: Stephane Eranian > --- > Jiri Olsa (14): > perf tools: Remove superfluous thread->comm_set setting > perf tools: Add feature check for lzma library > perf tools: Add lzma decompression support for kernel module > perf tools: Add kmod_path__parse function > perf tools: Add dsos__new function > perf tools: Add machine__module_dso function > perf tools: Use kmod_path__parse for machine__new_dso > perf tools: Use kmod_path__parse in map_groups__set_modules_path_dir > perf tools: Use kmod_path__parse in decompress_kmodule > perf tools: Use kmod_path__parse in is_kernel_module > perf tools: Remove compressed argument from is_kernel_module > perf tools: Remove is_kmodule_extension function > perf tools: Try to lookup kernel module map before creating one > perf annotate: Allow annotation for decompressed kernel modules > > tools/perf/Makefile.perf | 2 ++ > tools/perf/config/Makefile | 16 ++++++++-- > tools/perf/config/feature-checks/Makefile | 6 +++- > tools/perf/config/feature-checks/test-lzma.c | 10 ++++++ > tools/perf/tests/Build | 1 + > tools/perf/tests/builtin-test.c | 4 +++ > tools/perf/tests/kmod-path.c | 73 ++++++++++++++++++++++++++++++++++++++++++++ > tools/perf/tests/tests.h | 1 + > tools/perf/util/Build | 1 + > tools/perf/util/annotate.c | 32 +++++++++++++++++++- > tools/perf/util/dso.c | 52 ++++++++++++-------------------- > tools/perf/util/dso.h | 4 +-- > tools/perf/util/header.c | 2 +- > tools/perf/util/lzma.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tools/perf/util/machine.c | 142 +++++++++++++++++++++++++++++++++++++++++++++----------------------------------------- > tools/perf/util/symbol-elf.c | 25 ++++++++++----- > tools/perf/util/thread.c | 1 - > tools/perf/util/util.c | 66 ++++++++++++++++++++++++++++++++++++++++ > tools/perf/util/util.h | 18 +++++++++++ > 19 files changed, 436 insertions(+), 115 deletions(-) > create mode 100644 tools/perf/config/feature-checks/test-lzma.c > create mode 100644 tools/perf/tests/kmod-path.c > create mode 100644 tools/perf/util/lzma.c