From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "Cláudio Maia" <crrm@isep.ipp.pt>
Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings
Date: Wed, 4 Mar 2015 10:52:17 +0530 [thread overview]
Message-ID: <20150304052217.GA4336@sudip-PC> (raw)
In-Reply-To: <1425426439-17358-1-git-send-email-crrm@isep.ipp.pt>
On Tue, Mar 03, 2015 at 11:47:18PM +0000, Cláudio Maia wrote:
> Fixed two warnings occurring in lines that are over 80 characters and which are not comments.
commit message should not be more than 72 characters.
>
> Signed-off-by: Cláudio Maia <crrm@isep.ipp.pt>
> ---
<snip>
> static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
> {
> - fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
> + fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n",
> + __func__, xs, ys, xe, ye);
Alignment should match open parenthesis
regards
sudip
>
> /* H=0 Set X address of RAM */
next prev parent reply other threads:[~2015-03-04 5:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 23:47 [PATCH 1/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings Cláudio Maia
2015-03-03 23:47 ` [PATCH 2/2] " Cláudio Maia
2015-03-04 5:22 ` Sudip Mukherjee [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-04 11:11 [PATCH 1/2] " Cláudio Maia
2015-03-07 0:45 ` Greg KH
2015-03-03 12:54 Cláudio Maia
2015-03-03 13:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304052217.GA4336@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=crrm@isep.ipp.pt \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox