From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754389AbbCDFW3 (ORCPT ); Wed, 4 Mar 2015 00:22:29 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35615 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbbCDFW1 (ORCPT ); Wed, 4 Mar 2015 00:22:27 -0500 Date: Wed, 4 Mar 2015 10:52:17 +0530 From: Sudip Mukherjee To: =?iso-8859-1?Q?Cl=E1udio?= Maia Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings Message-ID: <20150304052217.GA4336@sudip-PC> References: <1425426439-17358-1-git-send-email-crrm@isep.ipp.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425426439-17358-1-git-send-email-crrm@isep.ipp.pt> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 03, 2015 at 11:47:18PM +0000, Cláudio Maia wrote: > Fixed two warnings occurring in lines that are over 80 characters and which are not comments. commit message should not be more than 72 characters. > > Signed-off-by: Cláudio Maia > --- > static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) > { > - fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye); > + fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", > + __func__, xs, ys, xe, ye); Alignment should match open parenthesis regards sudip > > /* H=0 Set X address of RAM */