From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754079AbbCDFYc (ORCPT ); Wed, 4 Mar 2015 00:24:32 -0500 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38297 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbbCDFYb (ORCPT ); Wed, 4 Mar 2015 00:24:31 -0500 Date: Wed, 4 Mar 2015 06:24:26 +0100 From: Ingo Molnar To: Brian Gerst Cc: x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, Borislav Petkov , Linus Torvalds Subject: Re: [PATCH 0/5] x86: IA32 emulation cleanups Message-ID: <20150304052426.GD5158@gmail.com> References: <1425439896-8322-1-git-send-email-brgerst@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425439896-8322-1-git-send-email-brgerst@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Brian Gerst wrote: > This series cleans up some files in the 32-bit emulation code, by merging > with the native 32-bit code, or in the case of the syscall audit, using the > generic compat code that was recently added. > > Brian Gerst (5): > x86: Remove compat_ni_syscall() > x86: Merge native and compat 32-bit syscall tables > x86: Remove sys32_vm86_warning > x86: Use generic compat audit code > x86: Clean up ia32/Makefile So this series is looking pretty good to me, I've picked up #1-#3, pending clarification on #4. I've stuck them into tip:x86/asm, because they might interact with ongoing system call entry work. While we are at it: CONFIG_IA32_EMULATION is a misnomer: there's nothing 'emulated' there, it's full software and hardware support for the 32-bit ABI. It's just an ugly (and somewhat confusing) replacement for CONFIG_COMPAT that most other architectures are using. So could we also get rid of CONFIG_IA32_EMULATION and change most of its uses over to CONFIG_COMPAT et al? The only complication with that might be that IA32_EMULATION kconfig switch hardcodes a few features currently: select BINFMT_ELF select COMPAT_BINFMT_ELF select HAVE_UID16 allowing the binfmt formats to be undefined should be OK; the uid16 dependency needs to be checked, whether it's safe to allow it to be disabled. Thanks, Ingo