Re: [PATCH 3.19 016/175] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU

Jiri Slaby
2015-05-11T07:53:18Z

On 05/11/2015, 09:37 AM, Michal Kubecek wrote:
> On Sat, May 02, 2015 at 05:14:50AM +0200, Mike Galbraith wrote:
>> On Fri, 2015-05-01 at 22:52 +0200, Greg Kroah-Hartman wrote:
>>> On Fri, May 01, 2015 at 03:00:00PM -0500, Josh Hunt wrote:
>>>> On Wed, Mar 4, 2015 at 12:13 AM, Greg Kroah-Hartman
>>>> <gregkh@linuxfoundation.org> wrote:
>>>>> 3.19-stable review patch. If anyone has any objections, please let me know.
>>>>>
>>>>> ------------------
>>>>>
>>>>> From: Calvin Owens <calvinowens@fb.com>
>>>>>
>>>>> commit 28423ad283d5348793b0c45cc9b1af058e776fd6 upstream.
>>>>>
>>>>> While debugging an issue with excessive softirq usage, I encountered the
>>>>> following note in commit 3e339b5dae24a706 ("softirq: Use hotplug thread
>>>>> infrastructure"):
>>>>>
>>>>> [ paulmck: Call rcu_note_context_switch() with interrupts enabled. ]

...

>>>> Sorry for the delay in noticing this, but should this be applied to
>>>> 3.14-stable as well?
>>>
>>> Why should it?
>>
>> The regression inducing change arrived in 3.7-rc1.
>
> I guess stable-3.12.y should have it too, then (with a trivial refresh
> for the comment added in 3.13).

Yes, I already put it into 3.12. Thanks.

--
js
suse labs