public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@freescale.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Liu Ying <Ying.Liu@freescale.com>, <linux-fbdev@vger.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] video: mxsfb: Make sure axi clock is enabled when accessing registers
Date: Wed, 4 Mar 2015 14:57:58 +0800	[thread overview]
Message-ID: <20150304065757.GB2689@shlinux2> (raw)
In-Reply-To: <20150304060817.GA12241@kroah.com>

On Tue, Mar 03, 2015 at 10:08:17PM -0800, Greg KH wrote:
> On Wed, Mar 04, 2015 at 01:58:55PM +0800, Liu Ying wrote:
> > The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock
> > as the engine's system clock.  The clock should be enabled when accessing
> > LCDIF registers, otherwise the kernel would hang up.  We should also keep
> > the clock being enabled when the engine is being active to scan out frames
> > from memory.  This patch makes sure the axi clock is enabled when accessing
> > registers so that the kernel hang up issue can be fixed.
> > 
> > Reported-by: Peter Chen <peter.chen@freescale.com>
> > Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> > ---
> >  drivers/video/fbdev/mxsfb.c | 70 ++++++++++++++++++++++++++++++++++++---------
> >  1 file changed, 56 insertions(+), 14 deletions(-)
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
> 
> </formletter>

Hi Greg,

I find this system hang issue at v4.0, and it should exist at v3.19 too.
Do you mean Ying forget to add tag "Cc: stable@vger.kernel.org # 3.19"
at commit log or you think this fix is too large?

-- 

Best Regards,
Peter Chen

  reply	other threads:[~2015-03-04  7:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04  5:58 [PATCH] video: mxsfb: Make sure axi clock is enabled when accessing registers Liu Ying
2015-03-04  6:08 ` Greg KH
2015-03-04  6:57   ` Peter Chen [this message]
2015-03-04  6:36 ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150304065757.GB2689@shlinux2 \
    --to=peter.chen@freescale.com \
    --cc=Ying.Liu@freescale.com \
    --cc=fabio.estevam@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=stable@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox