From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935492AbbCDHfK (ORCPT ); Wed, 4 Mar 2015 02:35:10 -0500 Received: from down.free-electrons.com ([37.187.137.238]:44116 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933380AbbCDHfH (ORCPT ); Wed, 4 Mar 2015 02:35:07 -0500 Date: Wed, 4 Mar 2015 08:35:05 +0100 From: Alexandre Belloni To: Wenyou Yang Cc: nicolas.ferre@atmel.com, linux@maxim.org.za, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sylvain.rochet@finsecur.com, patrice.vilchez@atmel.com, sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com Subject: Re: [PATCH] ARM: at91: pm: change at91_pm_set_standby() to static Message-ID: <20150304073505.GA3989@piout.net> References: <1425433485-902-1-git-send-email-wenyou.yang@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425433485-902-1-git-send-email-wenyou.yang@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2015 at 09:44:45 +0800, Wenyou Yang wrote : > Since at91_pm_set_standby() will not be used out of the pm.c file, > change its attribute from extern to static, remove its declaration as well. > > void at91_pm_set_standby(void (*at91_standby)(void)) > --> > static void at91_pm_set_standby(void (*at91_standby)(void)) > > Signed-off-by: Wenyou Yang Acked-by: Alexandre Belloni > --- > arch/arm/mach-at91/pm.c | 2 +- > arch/arm/mach-at91/pm.h | 6 ------ > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > index aa4116e..a4473dc 100644 > --- a/arch/arm/mach-at91/pm.c > +++ b/arch/arm/mach-at91/pm.c > @@ -218,7 +218,7 @@ static struct platform_device at91_cpuidle_device = { > .name = "cpuidle-at91", > }; > > -void at91_pm_set_standby(void (*at91_standby)(void)) > +static void at91_pm_set_standby(void (*at91_standby)(void)) > { > if (at91_standby) { > at91_cpuidle_device.dev.platform_data = at91_standby; > diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h > index 86c0aa8..86a9d0b 100644 > --- a/arch/arm/mach-at91/pm.h > +++ b/arch/arm/mach-at91/pm.h > @@ -15,12 +15,6 @@ > > #include > > -#ifdef CONFIG_PM > -extern void at91_pm_set_standby(void (*at91_standby)(void)); > -#else > -static inline void at91_pm_set_standby(void (*at91_standby)(void)) { } > -#endif > - > /* > * The AT91RM9200 goes into self-refresh mode with this command, and will > * terminate self-refresh automatically on the next SDRAM access. > -- > 1.7.9.5 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com