Re: [PATCH 1/2] livepatch: remove unnecessary call to klp_find_object_module()

[Petr Mladek <pmladek@suse.cz>]

On Tue 2015-03-03 17:02:21, Josh Poimboeuf wrote:
> klp_find_object_module() is called from both the klp register and enable
> paths.  Only the call from the register path is necessary because the
> module notifier will let us know if the patched module gets loaded or
> unloaded.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

Reviewed-by: Petr Mladek <pmladek@suse.cz>

Yup, the call is redundant.

Best Regards,
Petr

> ---
>  kernel/livepatch/core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index 01ca088..a74e4e8 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -541,8 +541,6 @@ static int __klp_enable_patch(struct klp_patch *patch)
>  	pr_notice("enabling patch '%s'\n", patch->mod->name);
>  
>  	for (obj = patch->objs; obj->funcs; obj++) {
> -		klp_find_object_module(obj);
> -
>  		if (!klp_is_object_loaded(obj))
>  			continue;
>  
> -- 
> 2.1.0
>