From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934048AbbCDJOO (ORCPT ); Wed, 4 Mar 2015 04:14:14 -0500 Received: from mail.skyhub.de ([78.46.96.112]:34049 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932108AbbCDJOK (ORCPT ); Wed, 4 Mar 2015 04:14:10 -0500 Date: Wed, 4 Mar 2015 10:12:56 +0100 From: Borislav Petkov To: Naoya Horiguchi Cc: Tony Luck , Prarit Bhargava , Vivek Goyal , "linux-kernel@vger.kernel.org" , Junichi Nomura , Kiyoshi Ueda Subject: Re: [PATCH v3 1/2] x86: mce: kexec: switch MCE handler for kexec/kdump Message-ID: <20150304091256.GE3233@pd.tnic> References: <1425373306-26187-1-git-send-email-n-horiguchi@ah.jp.nec.com> <20150303185324.GF25768@pd.tnic> <20150304075156.GB30501@hori1.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150304075156.GB30501@hori1.linux.bs1.fc.nec.co.jp> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 07:51:56AM +0000, Naoya Horiguchi wrote: > And the result of the update, the new code contains some > MCE-internal code, so I feel like putting most of the code in > arch/x86/kernel/cpu/mcheck/mce.c as in the previous versions. We can expose those defines for kdump's use if absolutely needed. mce.c is already not easy to stare at, having more stuff in it, while it can be avoided, is not something we want. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --