From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: berlin-usb: Use PTR_ERR_OR_ZERO
Date: Wed, 4 Mar 2015 10:14:11 +0100 [thread overview]
Message-ID: <20150304091411.GA3001@kwain> (raw)
In-Reply-To: <1425220294.13661.2.camel@phoenix>
On Sun, Mar 01, 2015 at 10:31:34PM +0800, Axel Lin wrote:
> PTR_ERR_OR_ZERO simplifies the code.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/phy/phy-berlin-usb.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index c8a8d53..9f7cc7e 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -202,10 +202,7 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
>
> phy_provider =
> devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate);
> - if (IS_ERR(phy_provider))
> - return PTR_ERR(phy_provider);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(phy_provider);
> }
>
> static struct platform_driver phy_berlin_usb_driver = {
> --
> 1.9.1
>
>
>
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-03-04 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 14:31 [PATCH] phy: berlin-usb: Use PTR_ERR_OR_ZERO Axel Lin
2015-03-04 9:14 ` Antoine Tenart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304091411.GA3001@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=axel.lin@ingics.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox