From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934132AbbCDJOU (ORCPT ); Wed, 4 Mar 2015 04:14:20 -0500 Received: from down.free-electrons.com ([37.187.137.238]:44771 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933326AbbCDJOO (ORCPT ); Wed, 4 Mar 2015 04:14:14 -0500 Date: Wed, 4 Mar 2015 10:14:11 +0100 From: Antoine Tenart To: Axel Lin Cc: Kishon Vijay Abraham I , Antoine Tenart , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] phy: berlin-usb: Use PTR_ERR_OR_ZERO Message-ID: <20150304091411.GA3001@kwain> References: <1425220294.13661.2.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425220294.13661.2.camel@phoenix> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 01, 2015 at 10:31:34PM +0800, Axel Lin wrote: > PTR_ERR_OR_ZERO simplifies the code. > > Signed-off-by: Axel Lin Acked-by: Antoine Tenart > --- > drivers/phy/phy-berlin-usb.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c > index c8a8d53..9f7cc7e 100644 > --- a/drivers/phy/phy-berlin-usb.c > +++ b/drivers/phy/phy-berlin-usb.c > @@ -202,10 +202,7 @@ static int phy_berlin_usb_probe(struct platform_device *pdev) > > phy_provider = > devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate); > - if (IS_ERR(phy_provider)) > - return PTR_ERR(phy_provider); > - > - return 0; > + return PTR_ERR_OR_ZERO(phy_provider); > } > > static struct platform_driver phy_berlin_usb_driver = { > -- > 1.9.1 > > > -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com