From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759845AbbCDJfH (ORCPT ); Wed, 4 Mar 2015 04:35:07 -0500 Received: from down.free-electrons.com ([37.187.137.238]:44919 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759211AbbCDJfD (ORCPT ); Wed, 4 Mar 2015 04:35:03 -0500 Date: Wed, 4 Mar 2015 10:32:15 +0100 From: Maxime Ripard To: Daniel Lezcano Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 5/5] clocksource: sun5i: Add clock notifiers Message-ID: <20150304093215.GI4911@lukather> References: <1422265856-27631-1-git-send-email-maxime.ripard@free-electrons.com> <1422265856-27631-6-git-send-email-maxime.ripard@free-electrons.com> <54C62368.7050600@linaro.org> <20150126143541.GG31568@lukather> <20150303085204.GA4911@lukather> <54F59829.2070205@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EdRE1UL8d3mMOE6m" Content-Disposition: inline In-Reply-To: <54F59829.2070205@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EdRE1UL8d3mMOE6m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 03, 2015 at 12:16:57PM +0100, Daniel Lezcano wrote: > On 03/03/2015 09:52 AM, Maxime Ripard wrote: > >On Mon, Jan 26, 2015 at 03:35:41PM +0100, Maxime Ripard wrote: > >>>>+static int sun5i_rate_cb_clksrc(struct notifier_block *nb, > >>>>+ unsigned long event, void *data) > >>>>+{ > >>>>+ struct clk_notifier_data *ndata =3D data; > >>>>+ struct sun5i_timer *timer =3D to_sun5i_timer(nb); > >>>>+ struct sun5i_timer_clksrc *cs =3D container_of(timer, > >>>>+ struct sun5i_timer_clksrc, timer); > >>>>+ > >>>>+ switch (event) { > >>>>+ case PRE_RATE_CHANGE: > >>>>+ clocksource_unregister(&cs->clksrc); > >>>>+ break; > >>>>+ > >>>>+ case POST_RATE_CHANGE: > >>>>+ clocksource_register_hz(&cs->clksrc, ndata->new_rate); > >>>>+ break; > >>> > >>>Why clocksource_unregister couldn't be in the POST_RATE_CHANGE ? > >> > >>Wouldn't that leave a (small, I agree) window where the timer would > >>run at a rate different to the one it has been registered with? > > > >Ping? >=20 > Hi Maxime, >=20 > except I missed something, there were a couple of comments and I was wait= ing > a V3. Indeed, but one of these comments (the one above) was still under discussion. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --EdRE1UL8d3mMOE6m Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU9tEfAAoJEBx+YmzsjxAgxqgP/2FBG0GMLet5rVbJ9JzUpIgX hQZQWRCoZocUaofgdDySS6Vl5rIHuvE55awvTe5nSPoqIN3G8gTUueV6sQD6x2OO MPaIJAWhZiM54DNWGUM3fq9gQPaybFxyE80xQwHFZr4LUQhL1o0L+tRO5iau8oy4 xK7D9rj61Hl8a0UJ5eMml3ig+SDZjUMosxo0acqtlUYEvCMa4k3NjecH6tiXoCi6 /2j+WJpTneJkGMIXQilpcr9Vhq+r+X7PnK+Xi/xfN9uMAg29wNlD9V4HaLQzjpHn wA5jWicU/eCA0zTAeXxw9NgVzd41QU3+bHCAl+bWPDvLYZBNKyKEKJ3GYhL2Kpw2 pDbUQgtTtyQ+r5Hp4diynEXlyZGB0oIoS+ABx0WrE7z+KCfkuG14AH5Y653qAkJi a5iRZgq7PfCK5LO5o2HA4wstCB6dOAIoeg+llyG9qkmMKqtdh/yyPIRQccyXhhER xppPyroMKT3b0XHs9y4rjm/zke1OYG0kzbWSc9liEEuoC67UluByGVnNGzX1mL8p qz3uhsDH2t45FJiVM262BaNaj8GksQdTpbi77vT+Mw8EMSy10qH7XXSsXDxNWltG bQpCvp6e3B7cC54nVjHjAFfpW3EfLjQtOK/CimIvCSl1KbOtTTEhGMNyqaYVKIph CaZOu1FkwbTOYZNvZBx1 =h/py -----END PGP SIGNATURE----- --EdRE1UL8d3mMOE6m--