From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758823AbbCDKYV (ORCPT ); Wed, 4 Mar 2015 05:24:21 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35671 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757095AbbCDKYS (ORCPT ); Wed, 4 Mar 2015 05:24:18 -0500 Date: Wed, 4 Mar 2015 11:24:15 +0100 From: Pavel Machek To: NeilBrown Cc: Samuel Ortiz , Tony Lindgren , Lee Jones , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , GTA04 owners , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 07/15] twl4030_charger: allow fine control of charger current. Message-ID: <20150304102415.GC30887@amd> References: <20150224043341.4243.23291.stgit@notabene.brown> <20150224043351.4243.88962.stgit@notabene.brown> <20150302210501.GJ13270@amd> <20150304174741.4b3af1ac@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150304174741.4b3af1ac@notabene.brown> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > does this help? > > /* > * For ichg_eoc, the hardware only supports reg values matching > * 100XXXX000, and requires the XXXX be stored in the high nibble > * of TWL4030_BCIMFTH8 > */ A bit, yes. Add "." at the end of sentence ;-). (Now I'd need to study the datasheets... and figure out how to enable this on N900). Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html