From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933135AbbCDKkg (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 05:40:36 -0500
Received: from mx2.parallels.com ([199.115.105.18]:48525 "EHLO
	mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758491AbbCDKkf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 05:40:35 -0500
Date: Wed, 4 Mar 2015 13:40:27 +0300
From: Vladimir Davydov <vdavydov@parallels.com>
To: Zefan Li <lizefan@huawei.com>
CC: Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Cgroups <cgroups@vger.kernel.org>, Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH -next] cpuset: initialize cpuset a bit early
Message-ID: <20150304104027.GC18131@esperanza>
References: <54F6CBCD.50009@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <54F6CBCD.50009@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 04, 2015 at 05:09:33PM +0800, Zefan Li wrote:
> Now we call ss->bind() in cgroup_init(), so cgroup_init() will
> call cpuset_bind() and then the latter will access top_cpuset's
> cpumask, which is NULL, because cpuset_init() is called after
> cgroup_init()
> 
> The simplest fix is to swap cgroup_init() and cpuset_init().
> 
> Cc: Vladimir Davydov <vdavydov@parallels.com>
> Fixes: 295458e67284 ("cgroup: call cgroup_subsys->bind on cgroup subsys initialization")
> Reported by: Ming Lei <tom.leiming@gmail.com>
> Signed-off-by: Zefan Li <lizefan@huawei.com>

Acked-by: Vladimir Davydov <vdavydov@parallels.com>

Thanks!