From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933449AbbCDL2z (ORCPT ); Wed, 4 Mar 2015 06:28:55 -0500 Received: from cantor2.suse.de ([195.135.220.15]:59333 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933384AbbCDL2x (ORCPT ); Wed, 4 Mar 2015 06:28:53 -0500 Date: Wed, 4 Mar 2015 12:27:40 +0100 From: Borislav Petkov To: Sudeep Holla Cc: Tejun Heo , Andre Przywara , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" Subject: Re: [PATCH RFT v2] x86: move cacheinfo sysfs to generic cacheinfo infrastructure Message-ID: <20150304112740.GB3663@pd.tnic> References: <20150224175749.GC3575@pd.tnic> <1425249564-28347-1-git-send-email-andre.przywara@arm.com> <20150303184527.GE3648@pd.tnic> <20150303185302.GA14909@htj.duckdns.org> <20150303185712.GF3648@pd.tnic> <54F6E965.4030301@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <54F6E965.4030301@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 11:15:49AM +0000, Sudeep Holla wrote: > I can do that, but wouldn't that add confusion as this commit is not > changing that behaviour. It's already changed in v4.0-rc1 Nah, this would add a reference to the fact that the cpumask format is not really a stable thing and thus cannot be considered a userpsace regression. And having this info is important IMO in case someone is wondering in the future. In general, having more and even redundant info in the commit messages is much better than having less info. I can't count the times I've been staring at a one-liner commit message and trying to rhyme up what was the purpose of doing it this way. So more is more, in this case. :-) Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --