From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760036AbbCDMt4 (ORCPT ); Wed, 4 Mar 2015 07:49:56 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:38125 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759446AbbCDMtx (ORCPT ); Wed, 4 Mar 2015 07:49:53 -0500 Date: Wed, 4 Mar 2015 18:19:48 +0530 From: Tapasweni Pathak To: vinholikatti@gmail.com, JBottomley@parallels.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: tapaswenipathak@gmail.com, julia.lawall@lip6.fr Subject: [PATCH] drivers: scsi: ufs: Fix possible null derefrence Message-ID: <20150304124948.GA3288@kt-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check for null before being dereferenced to avoid a invalid null dereference. Found using Coccinelle. Signed-off-by: Tapasweni Pathak Acked-by: Julia Lawall --- drivers/scsi/ufs/ufshcd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 5d60a86..c54e64f 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4268,12 +4268,15 @@ static int ufshcd_config_vreg(struct device *dev, struct ufs_vreg *vreg, bool on) { int ret = 0; - struct regulator *reg = vreg->reg; - const char *name = vreg->name; + struct regulator *reg; + const char *name; int min_uV, uA_load; BUG_ON(!vreg); + reg = vreg->reg; + name = vreg->name; + if (regulator_count_voltages(reg) > 0) { min_uV = on ? vreg->min_uV : 0; ret = regulator_set_voltage(reg, min_uV, vreg->max_uV); -- 1.7.9.5