From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758648AbbCDOjD (ORCPT ); Wed, 4 Mar 2015 09:39:03 -0500 Received: from seldrel01.sonyericsson.com ([212.209.106.2]:5163 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757194AbbCDOjA (ORCPT ); Wed, 4 Mar 2015 09:39:00 -0500 Date: Wed, 4 Mar 2015 06:38:53 -0800 From: Bjorn Andersson To: Stanimir Varbanov CC: Linus Walleij , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Stephen Boyd Subject: Re: [PATCH v2 2/2] pinctrl: qcom: handle input-enable pinconf property Message-ID: <20150304143853.GO26334@sonymobile.com> References: <1425465717-27747-1-git-send-email-svarbanov@mm-sol.com> <1425465717-27747-3-git-send-email-svarbanov@mm-sol.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1425465717-27747-3-git-send-email-svarbanov@mm-sol.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 04 Mar 02:41 PST 2015, Stanimir Varbanov wrote: > This enables support of 'input-enable' pinconf generic property in > the pinctrl driver. > > Signed-off-by: Stanimir Varbanov > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index d36e511..f3d800f 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -193,6 +193,7 @@ static int msm_config_reg(struct msm_pinctrl *pctrl, > *mask = 7; > break; > case PIN_CONFIG_OUTPUT: > + case PIN_CONFIG_INPUT_ENABLE: > *bit = g->oe_bit; > *mask = 1; > break; > @@ -260,6 +261,12 @@ static int msm_config_group_get(struct pinctrl_dev *pctldev, > val = readl(pctrl->regs + g->io_reg); > arg = !!(val & BIT(g->in_bit)); > break; > + case PIN_CONFIG_INPUT_ENABLE: > + /* Pin is output */ > + if (arg) > + return -EINVAL; > + arg = 1; > + break; I still don't like this part of the api, but the patch is Acked-by: Bjorn Andersson > default: > return -ENOTSUPP; > } Regards, Bjorn