From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932930AbbCDQFo (ORCPT ); Wed, 4 Mar 2015 11:05:44 -0500 Received: from mga09.intel.com ([134.134.136.24]:35842 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932641AbbCDQFl (ORCPT ); Wed, 4 Mar 2015 11:05:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,687,1418112000"; d="scan'208";a="536027335" Date: Wed, 4 Mar 2015 21:32:13 +0530 From: Vinod Koul To: Stanimir Varbanov Cc: Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] dmaengine: bam-dma: fill slave directions bit mask Message-ID: <20150304160213.GT2613@intel.com> References: <1425482710-23052-1-git-send-email-stanimir.varbanov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425482710-23052-1-git-send-email-stanimir.varbanov@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 05:25:10PM +0200, Stanimir Varbanov wrote: > This will avoid warning during async device registration. > > Signed-off-by: Stanimir Varbanov > --- > drivers/dma/qcom_bam_dma.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c > index c3113e3..cc9e5ee 100644 > --- a/drivers/dma/qcom_bam_dma.c > +++ b/drivers/dma/qcom_bam_dma.c > @@ -1143,6 +1143,7 @@ static int bam_dma_probe(struct platform_device *pdev) > dma_cap_set(DMA_SLAVE, bdev->common.cap_mask); > > /* initialize dmaengine apis */ > + bdev->common.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); > bdev->common.device_alloc_chan_resources = bam_alloc_chan; > bdev->common.device_free_chan_resources = bam_free_chan; > bdev->common.device_prep_slave_sg = bam_prep_slave_sg; You need to fill other fields, src/dstn_addr_widths and residue_granularity... -- ~Vinod