From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932694AbbCDQCV (ORCPT ); Wed, 4 Mar 2015 11:02:21 -0500 Received: from service87.mimecast.com ([91.220.42.44]:58633 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932461AbbCDQCT convert rfc822-to-8bit (ORCPT ); Wed, 4 Mar 2015 11:02:19 -0500 Date: Wed, 4 Mar 2015 16:02:15 +0000 From: Javi Merino To: Mark Brown Cc: Eduardo Valentin , Zhang Rui , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] thermal: Fix build for !CONFIG_THERMAL Message-ID: <20150304160215.GA2919@e104805> References: <1425470739-16651-1-git-send-email-broonie@kernel.org> MIME-Version: 1.0 In-Reply-To: <1425470739-16651-1-git-send-email-broonie@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginalArrivalTime: 04 Mar 2015 16:02:16.0168 (UTC) FILETIME=[95C61680:01D05694] X-MC-Unique: 115030416021715901 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Wed, Mar 04, 2015 at 12:05:39PM +0000, Mark Brown wrote: > Commit ddd4dd8ddf784 (thermal: extend the cooling device API to include > power information) added stubs for newly introduced functions when > !CONFIG_THERMAL but did not provide names for the parameters which is > a syntax error causing build errors in such configurations. Add names to > fix the issue. > > Also remove an extra semicolon from power_actor_set_power() which also > breaks the build and declare the functions as static inline to avoid > both multiple definitions and sparse warnings. > > Signed-off-by: Mark Brown This is already fixed in Eduardo's tree, but apparently the fix went in after linux-next merged its branch. It will be picked when linux-next merges it again. Thanks, Javi